Skip to content
This repository has been archived by the owner on May 5, 2022. It is now read-only.

Make timeout configurable #51

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Conversation

Igor-lkm
Copy link

@Igor-lkm Igor-lkm commented Jul 25, 2019

Problem: on some environments default timeout from tcp-ping probe (5000ms) is not enough.

This PR would replace probe with ping and introduced optional timeout, by default equal to 5000ms as before.

@CLAassistant
Copy link

CLAassistant commented Jul 25, 2019

CLA assistant check
All committers have signed the CLA.

@Igor-lkm Igor-lkm changed the title Make timeout configurable [WIP] Make timeout configurable Jul 25, 2019
@Igor-lkm
Copy link
Author

Also there were some problems with tests, caused by latency/delays, when tests are executed on travic-ci.

in waitAndGetTraces 1000ms is not enough to get results, work stable with 2000ms.
Before the request we need to connect successfully to zipkin. As there is no way we can find it out (event or promise returned) make sense to add startupDelay to give appmetrics-zipkin package time to connect.

@Igor-lkm Igor-lkm changed the title [WIP] Make timeout configurable Make timeout configurable Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants