-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Concurrent building occasionally cleans the Pods cache directory #11826 #11827
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: chengcong <646376172@qq.com>
…s the Pods cache directory
* origin/master: Changelog spacing Update changelog Fix typo in validation Two spaces update tests Xcode 14.3 fix: pod lib lint warning generation from main.m. Update integrations spec Add an entry to changelog. Pass the -f option when resolving the path to the symlinked source.
Thank you for the pr! 👏🏻 |
Hello @dnkoutso! can this one be merged? Thanks |
Based on my reading of the code: if In which case, this can be addressed without adding a lock using something like version_file = root + 'VERSION'
version = version_file.read.strip if version_file.file?
if version != Pod::VERSION
root.rmtree if root.exist?
root.mkpath
version_file.open('w') { |f| f << Pod::VERSION }
end (or, for extra safety, add the lock as well while only conditionally performing the write like I'm suggesting) |
For more details, please refer to #11826