BridgedNetwork implementation #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code-Hex
requested changes
Dec 9, 2023
|
@Code-Hex apologies for the delay, all the comments are now addressed |
|
I will release tomorrow in JST |
|
hey @Code-Hex , version bump still planned? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Found one issue related to that #138
Additional documentation
Added implementation for BridgedNetwork in order to be able to create network device using bridge network, rather than NAT.
Using BridgedNetwork does indeed require special entitlements from Apple, which is a whole PIA to setup and test by itself, as you need proper certificates and signing in place after you got it added to your Organization by Apple. My current project does have those entitlements and needs bridged network, so I was able to test this and it does the job. Please let me know your thoughts if anything needs to be improved.