Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version of golang.org/x/crypto to 0.18.0 to address authentication bypass vulnerability. #153

Closed
wants to merge 10 commits into from

Conversation

sam-caldwell
Copy link
Contributor

Bump version of golang.org/x/crypto to 0.18.0 to address authentication bypass vulnerability.

Ticket: #152

This PR bumps the version of a vulnerable package.

Which issue(s) this PR fixes:
Fixes ##152

Additional documentation
Defect identified by snyk.io scanner

Bump version of golang.org/x/crypto to 0.18.0 to address authentication bypass vulnerability.
Update go.mod golang.org/x/crypto version to patch authentication bypass by capture-replay vulnerability
@Code-Hex
Copy link
Owner

@sam-caldwell Could you fix compile errors?

@sam-caldwell
Copy link
Contributor Author

Will investigate in my next spare cycles.

@cfergeau
Copy link
Contributor

cfergeau commented Jan 23, 2024

Will investigate in my next spare cycles.

I've fixed this in https://github.com/cfergeau/vz/commits/go-ssh/ in the fix go vetcommit (ran go mod tidyin the root dir and in example/*/
github dependabot can watch dependencies and file PR automatically, I've added the configuration file for this in use dependabot for automatic dependency upgrades
I can file a PR for this if that's desirable to have (imo it is useful)

@sam-caldwell
Copy link
Contributor Author

@cfergeau good call out with dependabot. I use both snyk and dependabot regularly, and they are great tools for any repo.

@Code-Hex fixes should be in, just waiting for github actions to fire and run the build. I'll have more spare cycles tomorrow morning so long as PagerDuty is willing. :-)

Cheers!

Sam

@Code-Hex
Copy link
Owner

Code-Hex commented Jan 23, 2024

@sam-caldwell Thanks
Could you remove dependabot target for examples? If done it I will merge this PR

@sam-caldwell
Copy link
Contributor Author

Found two additional issues in the PR. Sorry for the messy PR...just trying to learn your codebase. :-)

  • bumped the example go.mod/go.sum versions

Copy link
Owner

@Code-Hex Code-Hex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please only make the corrections that I specify.

@@ -23,7 +23,7 @@ jobs:
build:
needs: formatting-check
runs-on: ${{ matrix.os }}
timeout-minutes: 6
timeout-minutes: 15
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please Revert this one

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You asked me to help fix your broken builds. The build is timing out. Increasing this value now has two of the builds passing.

@sam-caldwell
Copy link
Contributor Author

Closing Pull request. Maintainer is more interested in control than fixes

@Code-Hex
Copy link
Owner

@sam-caldwell I'm very sad because cannot merge this PR

@cfergeau
Copy link
Contributor

@sam-caldwell I took this over in #155 and kept your name on the commit, let me know if this is a problem and want something different.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants