Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make toggling utility area maximization smooth #1701

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

danielzsh
Copy link
Contributor

Description

Before:

Screen.Recording.2024-05-03.at.9.15.59.AM.mov

After:

Screen.Recording.2024-05-03.at.9.16.20.AM.mov

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

Copy link
Collaborator

@thecoolwinter thecoolwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen.Recording.2024-05-03.at.11.33.44.AM.mov

This seems to introduce a bug. It does fix itself once the utility area has been toggled though, so maybe it's related to some area toggling logic?

@danielzsh
Copy link
Contributor Author

Hm, I can't seem to reproduce:

Screen.Recording.2024-05-03.at.10.49.05.AM.mov

This is after quitting and reopening, without touching anything else other than the top edge of the window.

@danielzsh
Copy link
Contributor Author

Oh nevermind, I'm seeing it now too...will see if there's an easy fix 😓

@danielzsh
Copy link
Contributor Author

danielzsh commented May 4, 2024

While debugging this I discovered a new issue (both on this branch and on main as well):

Screen.Recording.2024-05-03.at.6.41.24.PM.mov

The bottom of the window gets forced down when maximizing the utility area for some reason, after it's been minimized and reopened...

This issue also occurs sometimes even without minimizing/reopening, but I can't find reliable ways to repro them.

@danielzsh
Copy link
Contributor Author

The issue you noted earlier should be resolved now, but the issue I commented on above still stands; any ideas perhaps on how to fix it/what could be causing it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants