[Feature] Add Edit Functionality #383
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/codeforafrica/PromiseTracker/DRBWYwTYQio7ZtJT1APd5sQDVxRm |
kilemensi
reviewed
Apr 14, 2022
There was a problem hiding this comment.
👍🏽 @nerdlet
- We only need one access point
/accounts/profile. When you receive aGET, you return current profile. When you receivePATCH, you update the profile. - No need to pass the profile id from client to the server. The server should pull the id from the session after calling
const session = await getSession({ req });. This way, we ensure you can only update your profile rather than me login in and passing your id to the server.
Also the alert should only be displayed when someone updates their profile. Notice I just close the dialog without updating anything and yet I get the alert.
src/pages/api/accounts/index.js
Outdated
Comment on lines
16
to
18
| if (req.method === "GET") { | ||
| return registerNewUser(req, res); | ||
| } |
There was a problem hiding this comment.
Why would we want to register a new user with GET?
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes # (issue)
Type of change
Desktop Screenshots
Mobile Screenshots
Checklist: