New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open graph + favicons #40
Conversation
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/codeforafrica/promisetracker/4dokvstmk |
@kilemensi Not sure of this implementation per say, with the open graph stuff...let me know what you think |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 @nerdlet ... I'm down with this approach.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good
@kilemensi Ran into an issue when implementing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
I don't experience this @nerdlet ... This code with import { DefaultSeo } from 'next-seo';
import SEO from '../next-seo.config';
class PromiseTrackerApp extends App {
componentDidMount() {
// Remove the server-side injected CSS.
const jssStyles = document.querySelector('#jss-server-side');
if (jssStyles) {
jssStyles.parentElement.removeChild(jssStyles);
}
}
render() {
const { Component, pageProps } = this.props;
return (
<>
<MuiThemeProvider theme={theme}>
<CssBaseline />
<DefaultSeo {...SEO} />
<Component {...pageProps} />
</MuiThemeProvider>
</>
);
}
} |
@kilemensi It should be good now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 @nerdlet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 🚀 @nerdlet
title: 'Promise tracker', | ||
description: | ||
'PromiseTracker, is a tool to help journalists and civil society watchdogs more easily track campaign promises and other political / government pledges', | ||
image: `${config.url}/public/image/openGraph.png`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
image:
can be removed now.
Description
Fixes #170767031
Type of change
Desktop Screenshots
Mobile Screenshots
Checklist: