Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open graph + favicons #40

Merged
merged 14 commits into from Feb 4, 2020
Merged

Open graph + favicons #40

merged 14 commits into from Feb 4, 2020

Conversation

nerdlet
Copy link
Contributor

@nerdlet nerdlet commented Jan 31, 2020

Description

Fixes #170767031

Type of change

  • New feature (non-breaking change which adds functionality)

Desktop Screenshots

Screenshot 2020-01-31 at 16 59 44

Mobile Screenshots

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@nerdlet nerdlet added the enhancement New feature or request label Jan 31, 2020
@vercel
Copy link

vercel bot commented Jan 31, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/codeforafrica/promisetracker/4dokvstmk
✅ Preview: https://promisetracker-git-feature-add-favicons.codeforafrica.now.sh

@nerdlet
Copy link
Contributor Author

nerdlet commented Jan 31, 2020

@kilemensi Not sure of this implementation per say, with the open graph stuff...let me know what you think

Copy link
Member

@kilemensi kilemensi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 @nerdlet ... I'm down with this approach.

src/pages/_app.js Outdated Show resolved Hide resolved
public/manifest.json Show resolved Hide resolved
Copy link

@karimkawambwa karimkawambwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

src/pages/_app.js Outdated Show resolved Hide resolved
@nerdlet
Copy link
Contributor Author

nerdlet commented Feb 3, 2020

@kilemensi Ran into an issue when implementing DefaultSeo component. The issue is addressed here: [https://github.com/vercel/next.js/issues/10333] Fixed this by just using NextSeo instead of DefaultSeo

Copy link
Member

@kilemensi kilemensi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

package.json Outdated Show resolved Hide resolved
public/manifest.json Outdated Show resolved Hide resolved
src/next-seo.config.js Outdated Show resolved Hide resolved
src/next-seo.config.js Outdated Show resolved Hide resolved
@kilemensi
Copy link
Member

@kilemensi Ran into an issue when implementing DefaultSeo component. The issue is addressed here: [https://github.com/zeit/next.js/issues/10333] Fixed this by just using NextSeo instead of DefaultSeo

I don't experience this @nerdlet ... This code with DefaultSeo works as advertised:

import { DefaultSeo } from 'next-seo';
import SEO from '../next-seo.config';

class PromiseTrackerApp extends App {
  componentDidMount() {
    // Remove the server-side injected CSS.
    const jssStyles = document.querySelector('#jss-server-side');
    if (jssStyles) {
      jssStyles.parentElement.removeChild(jssStyles);
    }
  }

  render() {
    const { Component, pageProps } = this.props;
    return (
      <>
        <MuiThemeProvider theme={theme}>
          <CssBaseline />
          <DefaultSeo {...SEO} />
          <Component {...pageProps} />
        </MuiThemeProvider>
      </>
    );
  }
}

@nerdlet
Copy link
Contributor Author

nerdlet commented Feb 4, 2020

@kilemensi It should be good now

Copy link
Member

@kilemensi kilemensi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 @nerdlet

src/next-seo.config.js Outdated Show resolved Hide resolved
src/next-seo.config.js Show resolved Hide resolved
Copy link
Member

@kilemensi kilemensi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀 @nerdlet

title: 'Promise tracker',
description:
'PromiseTracker, is a tool to help journalists and civil society watchdogs more easily track campaign promises and other political / government pledges',
image: `${config.url}/public/image/openGraph.png`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image: can be removed now.

@nerdlet nerdlet merged commit 432a86f into master Feb 4, 2020
@kilemensi kilemensi deleted the feature/add-favicons branch September 2, 2020 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants