Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace hardcoded repository name in rlocation paths #280

Closed
wants to merge 1 commit into from

Conversation

fmeum
Copy link
Contributor

@fmeum fmeum commented Jan 10, 2022

This is in preparation for Bazel module support, where repositories are
assigned internal names different from their declared user-facing name.

@fmeum fmeum force-pushed the repository-relative-runfiles branch 2 times, most recently from 01ad598 to 4d27926 Compare January 10, 2022 07:30
This is in preparation for Bazel module support, where repositories are
assigned internal names different from their declared user-facing name.
@fmeum fmeum force-pushed the repository-relative-runfiles branch from 4d27926 to f01e0eb Compare January 10, 2022 07:50
@fmeum fmeum marked this pull request as draft January 10, 2022 10:16
@fmeum
Copy link
Contributor Author

fmeum commented Jan 10, 2022

The tests don't pass from an external repository. rootpath still evaluates to a path under external rather than ../, so this needs special handling.

@fmeum fmeum self-assigned this Jan 10, 2022
@fmeum
Copy link
Contributor Author

fmeum commented Aug 8, 2022

Waiting for bazelbuild/proposals#269 instead.

@fmeum fmeum closed this Aug 8, 2022
@fmeum fmeum deleted the repository-relative-runfiles branch August 8, 2022 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant