Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4주차 1번째 과제 #60

Merged
merged 55 commits into from May 31, 2021
Merged

4주차 1번째 과제 #60

merged 55 commits into from May 31, 2021

Commits on May 24, 2021

  1. npm install하라

    @yujonglee
    yujonglee committed May 24, 2021
    Configuration menu
    Copy the full SHA
    fd626f1 View commit details
    Browse the repository at this point in the history

  2. 상태변화로직을 App에서 분리하라

    @yujonglee
    yujonglee committed May 24, 2021
    Configuration menu
    Copy the full SHA
    220fe98 View commit details
    Browse the repository at this point in the history

  3. redux를 도입하라

    @yujonglee
    yujonglee committed May 24, 2021
    Configuration menu
    Copy the full SHA
    ee39385 View commit details
    Browse the repository at this point in the history

  4. reducer을 파일로 분리하고 테스트파일을 생성하라

    @yujonglee
    yujonglee committed May 24, 2021
    Configuration menu
    Copy the full SHA
    0afb159 View commit details
    Browse the repository at this point in the history

  5. updateTitle을 updateTaskTitle로 변경하라

    @yujonglee
    yujonglee committed May 24, 2021
    Configuration menu
    Copy the full SHA
    79bf644 View commit details
    Browse the repository at this point in the history

  6. updateTaskTitle 리듀서 테스트를 작성하라

    @yujonglee
    yujonglee committed May 24, 2021
    Configuration menu
    Copy the full SHA
    c493676 View commit details
    Browse the repository at this point in the history

  7. updateTaskTitle 리듀서를 작성하라

    @yujonglee
    yujonglee committed May 24, 2021
    Configuration menu
    Copy the full SHA
    7c0cb26 View commit details
    Browse the repository at this point in the history

  8. AddTask 리듀서 테스트를 작성하라

    @yujonglee
    yujonglee committed May 24, 2021
    Configuration menu
    Copy the full SHA
    384e142 View commit details
    Browse the repository at this point in the history

  9. AddTask 리듀서를 작성하라

    @yujonglee
    yujonglee committed May 24, 2021
    Configuration menu
    Copy the full SHA
    4d9637f View commit details
    Browse the repository at this point in the history

  10. DeleteTask 리듀서 테스트를 작성하라

    @yujonglee
    yujonglee committed May 24, 2021
    Configuration menu
    Copy the full SHA
    28d414e View commit details
    Browse the repository at this point in the history

  11. DeleteTask 리듀서를 작성하라

    @yujonglee
    yujonglee committed May 24, 2021
    Configuration menu
    Copy the full SHA
    33aac4d View commit details
    Browse the repository at this point in the history

  12. 리듀서의 반복된 if문을 switch문으로 대체하라

    @yujonglee
    yujonglee committed May 24, 2021
    Configuration menu
    Copy the full SHA
    e809245 View commit details
    Browse the repository at this point in the history

  13. 리듀서 테스트에 context를 추가하라

    @yujonglee
    yujonglee committed May 24, 2021
    Configuration menu
    Copy the full SHA
    3faf51a View commit details
    Browse the repository at this point in the history

  14. add task without title 테스트를 추가하라

    @yujonglee
    yujonglee committed May 24, 2021
    Configuration menu
    Copy the full SHA
    527b42e View commit details
    Browse the repository at this point in the history

  15. add task without title 테스트를 통과하도록 수정하라

    @yujonglee
    yujonglee committed May 24, 2021
    Configuration menu
    Copy the full SHA
    dd2b945 View commit details
    Browse the repository at this point in the history

  16. delete task with non-existing id 테스트를 추가하라

    @yujonglee
    yujonglee committed May 24, 2021
    Configuration menu
    Copy the full SHA
    d7a5350 View commit details
    Browse the repository at this point in the history

  17. 액션생성함수를 도입하라

    @yujonglee
    yujonglee committed May 24, 2021
    Configuration menu
    Copy the full SHA
    05da2a7 View commit details
    Browse the repository at this point in the history

  18. reducer.js에서 화살표함수를 제거하라

    @yujonglee
    yujonglee committed May 24, 2021
    Configuration menu
    Copy the full SHA
    f5db30d View commit details
    Browse the repository at this point in the history

  19. useSelector, useDispatch를 mock하여 App컴포넌트 테스트를 준비하라

    @yujonglee
    yujonglee committed May 24, 2021
    Configuration menu
    Copy the full SHA
    91685e5 View commit details
    Browse the repository at this point in the history

  20. App 테스트를 작성하라

    @yujonglee
    yujonglee committed May 24, 2021
    Configuration menu
    Copy the full SHA
    0560273 View commit details
    Browse the repository at this point in the history

  21. App에서 useState를 제거하고 redux를 도입하라

    @yujonglee
    yujonglee committed May 24, 2021
    Configuration menu
    Copy the full SHA
    70f2a63 View commit details
    Browse the repository at this point in the history

  22. reducer에서 매개변수 기본값과 switch-case기본값을 테스트하라

    @yujonglee
    yujonglee committed May 24, 2021
    Configuration menu
    Copy the full SHA
    f633727 View commit details
    Browse the repository at this point in the history

  23. user-Event를 설치하라

    @yujonglee
    yujonglee committed May 24, 2021
    Configuration menu
    Copy the full SHA
    9adaf7d View commit details
    Browse the repository at this point in the history

  24. given2를 설치하라

    @yujonglee
    yujonglee committed May 24, 2021
    Configuration menu
    Copy the full SHA
    d3d0fa0 View commit details
    Browse the repository at this point in the history

  25. eslint설정을 추가하라

    @yujonglee
    yujonglee committed May 24, 2021
    Configuration menu
    Copy the full SHA
    96d0055 View commit details
    Browse the repository at this point in the history

  26. App테스트를 리팩터링하라

    @yujonglee
    yujonglee committed May 24, 2021
    Configuration menu
    Copy the full SHA
    52fc06f View commit details
    Browse the repository at this point in the history

  27. 불필요한 expect문을 삭제하라

    @yujonglee
    yujonglee committed May 24, 2021
    Configuration menu
    Copy the full SHA
    e462aa8 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2021

  1. 이벤트 객체를 헨들러에서 처리하도록 수정하라

    @yujonglee
    yujonglee committed May 25, 2021
    Configuration menu
    Copy the full SHA
    bf24902 View commit details
    Browse the repository at this point in the history

  2. userEvent에서 발생하는 문제를 fireEvent를 도입하여 해결하라

    @yujonglee
    yujonglee committed May 25, 2021
    Configuration menu
    Copy the full SHA
    1e47de1 View commit details
    Browse the repository at this point in the history

  3. 개발과정 중 불필요하게 남겨진 클릭이벤트를 제거하라

    @yujonglee
    yujonglee committed May 25, 2021
    Configuration menu
    Copy the full SHA
    76fe63f View commit details
    Browse the repository at this point in the history

  4. mock clear을 이용해 let을 제거하라

    @yujonglee
    yujonglee committed May 25, 2021
    Configuration menu
    Copy the full SHA
    ce7105e View commit details
    Browse the repository at this point in the history

  5. 오타를 수정하라

    @yujonglee
    yujonglee committed May 25, 2021
    Configuration menu
    Copy the full SHA
    3e8c755 View commit details
    Browse the repository at this point in the history

  6. context의 대비를 고려하여 테스트코드 구조를 수정하라

    @yujonglee
    yujonglee committed May 25, 2021
    Configuration menu
    Copy the full SHA
    529cd26 View commit details
    Browse the repository at this point in the history

  7. 액션타입이름을 읽기 좋게 수정하라

    @yujonglee
    yujonglee committed May 25, 2021
    Configuration menu
    Copy the full SHA
    5b812ac View commit details
    Browse the repository at this point in the history

  8. 테스트코드에서 액션객체를 직접 사용하지 말고 액션생성함수를 사용하도록 수정하라

    @yujonglee
    yujonglee committed May 25, 2021
    Configuration menu
    Copy the full SHA
    e81648d View commit details
    Browse the repository at this point in the history

  9. 리듀서에서 switch문을 제거하라

    @yujonglee
    yujonglee committed May 25, 2021
    Configuration menu
    Copy the full SHA
    0d64e7a View commit details
    Browse the repository at this point in the history

  10. 반복되는 useSelector mock implementation코드를 beforeEach로 옮겨라

    @yujonglee
    yujonglee committed May 25, 2021
    Configuration menu
    Copy the full SHA
    b0c928e View commit details
    Browse the repository at this point in the history

  11. toBeInTheDocument를 사용하여 테스트 가독성을 개선하라

    @yujonglee
    yujonglee committed May 25, 2021
    Configuration menu
    Copy the full SHA
    3e51996 View commit details
    Browse the repository at this point in the history

  12. 폴더 구조를 변경하라

    @yujonglee
    yujonglee committed May 25, 2021
    Configuration menu
    Copy the full SHA
    406ce5f View commit details
    Browse the repository at this point in the history

  13. InputContainer 테스트를 작성하라

    @yujonglee
    yujonglee committed May 25, 2021
    Configuration menu
    Copy the full SHA
    f3fa683 View commit details
    Browse the repository at this point in the history

  14. InputContainer를 작성하라

    @yujonglee
    yujonglee committed May 25, 2021
    Configuration menu
    Copy the full SHA
    70b673e View commit details
    Browse the repository at this point in the history

  15. App 테스트 일부를 InputContainer테스트로 옮겨라

    @yujonglee
    yujonglee committed May 25, 2021
    Configuration menu
    Copy the full SHA
    9be1239 View commit details
    Browse the repository at this point in the history

  16. Input의 불필요한 테스트를 삭제하고 렌더링을 확인하는 테스트만 남겨라

    @yujonglee
    yujonglee committed May 25, 2021
    Configuration menu
    Copy the full SHA
    a3e5891 View commit details
    Browse the repository at this point in the history

  17. InputContainer을 상위에서 Input대신 사용하게하라

    @yujonglee
    yujonglee committed May 25, 2021
    Configuration menu
    Copy the full SHA
    0126875 View commit details
    Browse the repository at this point in the history

  18. InputContainer 테스트에서 beforeEach로 중복을 제거하라

    @yujonglee
    yujonglee committed May 25, 2021
    Configuration menu
    Copy the full SHA
    d9f1272 View commit details
    Browse the repository at this point in the history

  19. List 테스트에서 불필요한 테스트를 제거하

    @yujonglee
    yujonglee committed May 25, 2021
    Configuration menu
    Copy the full SHA
    8e42a7b View commit details
    Browse the repository at this point in the history

  20. ListContainer테스트를 작성하라

    @yujonglee
    yujonglee committed May 25, 2021
    Configuration menu
    Copy the full SHA
    ef975fb View commit details
    Browse the repository at this point in the history

  21. ListContainer를 작성하라

    @yujonglee
    yujonglee committed May 25, 2021
    Configuration menu
    Copy the full SHA
    5893201 View commit details
    Browse the repository at this point in the history

  22. ListContainer를 상위 컴포넌트에서 사용하게하라

    @yujonglee
    yujonglee committed May 25, 2021
    Configuration menu
    Copy the full SHA
    afdd9aa View commit details
    Browse the repository at this point in the history

  23. Page를 TodoPage로 rename하라

    @yujonglee
    yujonglee committed May 25, 2021
    Configuration menu
    Copy the full SHA
    396502d View commit details
    Browse the repository at this point in the history

  24. 셀렉터로 필요한 값만 상태에서 가져오도록 하라

    @yujonglee
    yujonglee committed May 25, 2021
    Configuration menu
    Copy the full SHA
    c9492ce View commit details
    Browse the repository at this point in the history

  25. 컨테이너를 도입하면서 불필요해진 테스트를 삭제하라

    @yujonglee
    yujonglee committed May 25, 2021
    Configuration menu
    Copy the full SHA
    9122174 View commit details
    Browse the repository at this point in the history

  26. 테스트가 1개뿐이라 굳이 묶어줄 필요없는 descibe블럭을 삭제하라

    @yujonglee
    yujonglee committed May 25, 2021
    Configuration menu
    Copy the full SHA
    e87f398 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2021

  1. 불필요한 TodoPage를 제거하고 그 내용을 App으로 옮겨라

    @yujonglee
    yujonglee committed May 26, 2021
    Configuration menu
    Copy the full SHA
    803fe83 View commit details
    Browse the repository at this point in the history

  2. 테스트들을 describe블럭으로 묶어라

    @yujonglee
    yujonglee committed May 26, 2021
    Configuration menu
    Copy the full SHA
    72a27f6 View commit details
    Browse the repository at this point in the history