Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Disclosure): creating an Disclosure component #2859

Draft
wants to merge 42 commits into
base: main
Choose a base branch
from
Draft

feat(Disclosure): creating an Disclosure component #2859

wants to merge 42 commits into from
+788 −0

Conversation

LinKCoding
Copy link
Contributor

@LinKCoding LinKCoding commented Apr 12, 2024 •
edited by jira bot

Overview

Adding a Disclosure component to replace the current AccordionDeprecated component.

PR Checklist

Testing Instructions

  1. Click on the preview link
  2. Go to the path=/docs/molecules-disclosure--disclosure
  3. Read through the documentation
  4. Change around the props in the Code Playground example
  5. ...
  6. Profit!

Don't make me tap the sign.

@LinKCoding LinKCoding changed the title feat(Accordion): creating an Accordion component feat(Disclosure): creating an Disclosure component May 7, 2024
dreamwasp
dreamwasp reviewed May 23, 2024
View reviewed changes
Copy link
Contributor

@dreamwasp dreamwasp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is looking great! left some comments but mostly code organizations things~

packages/styleguide/stories/Molecules/Disclosure/index.stories.mdx Show resolved Hide resolved
packages/styleguide/stories/Molecules/Disclosure/index.stories.mdx Outdated Show resolved Hide resolved
packages/styleguide/stories/Molecules/Disclosure/index.stories.mdx Show resolved Hide resolved
packages/styleguide/stories/Molecules/Disclosure/index.stories.mdx Outdated Show resolved Hide resolved
packages/gamut/src/Disclosure/types.ts Outdated Show resolved Hide resolved
packages/gamut/src/Disclosure/DisclosureButton/index.tsx Outdated Show resolved Hide resolved
packages/gamut/src/Disclosure/DisclosureButton/index.tsx Outdated
bg: 'background-disabled',
},
},
// Don't actually need the variant here, but it errors out if omitted
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't understand this review comment, we can pair on it!

packages/gamut/src/Disclosure/DisclosureBody/index.tsx Outdated Show resolved Hide resolved
packages/gamut/src/Animation/ExpandInCollapseOut.tsx Show resolved Hide resolved
packages/gamut/src/Disclosure/helpers.tsx Outdated Show resolved Hide resolved
@codecademydev
Copy link
Collaborator

📬Published Alpha Packages:

@codecademy/gamut@55.21.3-alpha.9ceeb2.0
@codecademy/gamut-kit@0.6.412-alpha.9ceeb2.0
@codecademy/styleguide@66.22.1-alpha.9ceeb2.0

@codecademydev
Copy link
Collaborator

🚀 Styleguide deploy preview ready!

https://6661cbe2d83d960b42bd0537--gamut-preview.netlify.app

Deploy Logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreamwasp dreamwasp dreamwasp left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@LinKCoding @codecademydev @dreamwasp