Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revised dark mode box shadow for cards #2866

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

j10sanders
Copy link
Contributor

Overview

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: [ABC-123]
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

Don't make me tap the sign.

PR Links and Envs

Repository PR Link PR Env
Monolith Monolith PR Monolith Env
Portal Portal Link Portal Env
Another Repo Another Link Another Env

@j10sanders j10sanders requested a review from a team as a code owner April 18, 2024 13:32
@codecademydev
Copy link
Collaborator

📬Published Alpha Packages:

@codecademy/gamut@55.17.4-alpha.85f0ec.0
@codecademy/gamut-kit@0.6.401-alpha.85f0ec.0
@codecademy/styleguide@66.17.5-alpha.85f0ec.0

@codecademydev
Copy link
Collaborator

🚀 Styleguide deploy preview ready!

https://662123c22e61341d6922e85f--gamut-preview.netlify.app

Deploy Logs

@BandanaKM
Copy link
Contributor

@j10sanders i see we are tagged here, but there is no description or testing instructions. mind adding that and linking to what prompted this pr?

mode === 'dark' ? theme.colors['background-current'] : 'currentColor'
theme.colors['background-current']
}, -8px 8px 0 1px ${
mode === 'dark' && !variant ? 'white' : theme.colors.black
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise, this looks pretty good! just more curious about the context and instructions to test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants