Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Config): Switch to canary release on next branch #916

Merged
merged 2 commits into from Aug 13, 2020

Conversation

codecaaron
Copy link
Contributor

Overview

Switches to a canary release on next which should produce a x.x.x.next.0 version also removes the github release option.

PR Checklist

  • Related to Abstract designs:
  • Related to JIRA ticket: ABC-123
  • I have run this code to verify it works
  • This PR includes unit tests for the code change

@codecaaron codecaaron requested a review from a team as a code owner August 12, 2020 23:09
@@ -163,7 +163,7 @@ jobs:
- *set_npm_token
- run:
name: Lerna Publish
command: yarn lerna publish --yes --conventional-commits --changelog-preset conventionalcommits --include-merged-tags --preid next --dist-tag next
command: yarn lerna publish --canary --preid=next --dist-tag=next
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, —canary doesn’t work w/ conventional commits?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov
Copy link

codecov bot commented Aug 12, 2020

Codecov Report

Merging #916 into main will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #916   +/-   ##
=======================================
  Coverage   62.46%   62.46%           
=======================================
  Files         212      212           
  Lines        1769     1769           
  Branches      634      640    +6     
=======================================
  Hits         1105     1105           
  Misses        659      659           
  Partials        5        5           

@codecademydev
Copy link
Collaborator

🚀 Styleguide deploy preview ready!

https://5f3479b37abc91008d4e3d6d--gamut-preview.netlify.app

Deploy Logs

@codecaaron codecaaron merged commit a17eb0e into main Aug 13, 2020
@codecaaron codecaaron deleted the ar-update-next-publish branch August 13, 2020 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants