Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement GIS Implicit flow for web #259

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

axi
Copy link

@axi axi commented Feb 7, 2023

An implementation with implicit flow which supports scopes.
There are still some things to figure out:

  • Not sure about the refresh() case: is it still needed if grantOfflineAccess is not supported anymore ?
  • As stated here, I didn't choose Authorization code flow because it would now require a backend platform to host an authorization code endpoint.

@axi axi mentioned this pull request Feb 7, 2023
@axi
Copy link
Author

axi commented Feb 22, 2023

This should fix #202 but I need some opinions on this one, @reslear maybe ?

@reslear
Copy link
Collaborator

reslear commented Feb 22, 2023

Hey, cool, but we need more code flow also

@axi
Copy link
Author

axi commented Feb 28, 2023

I don't get why we should have code flow, it wasn't the case before, is it ?

@sjdrew
Copy link

sjdrew commented Mar 10, 2023

@axi thanks for this. Can we get this merged before google shuts us down?

@sjdrew
Copy link

sjdrew commented Mar 10, 2023

@axi one minor suggestion. the scriptId you have as "gapi" but this is actually loading the GIS Library which loads itself onto the window as 'google'.

The GAPI Library, loads itself onto the window object as 'gapi' .

So would just be less confusing if you named that scriptId tag "gis".

@axi
Copy link
Author

axi commented Mar 10, 2023

I don't know what to do next without guidance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants