Skip to content
This repository has been archived by the owner on Mar 9, 2022. It is now read-only.

[CA-123] Cypress Setup #13

Merged
merged 13 commits into from
Sep 6, 2019
Merged

[CA-123] Cypress Setup #13

merged 13 commits into from
Sep 6, 2019

Conversation

tejas-hosamani
Copy link
Contributor

@tejas-hosamani tejas-hosamani commented Aug 29, 2019

Cypress setup is complete. But running into an issue related to the pre-commit hook.
Tests themselves run okay but pre-commit is exiting with an error.

This issue is being tracked on Husky as well as Cypress.

Could you guys take a look and see if you can do something about it?

Error:

_stream_readable.js:651
    dest.end();
         ^

TypeError: dest.end is not a function
    at Socket.onend (_stream_readable.js:651:10)
    at Object.onceWrapper (events.js:277:13)
    at Socket.emit (events.js:194:15)
    at endReadableNT (_stream_readable.js:1125:12)
    at process._tickCallback (internal/process/next_tick.js:63:19)

@tejas-hosamani
Copy link
Contributor Author

cypress/integration/App.spec.js Outdated Show resolved Hide resolved
cypress/integration/App.spec.js Outdated Show resolved Hide resolved
cypress/integration/App.spec.js Outdated Show resolved Hide resolved
cypress/plugins/index.js Outdated Show resolved Hide resolved
cypress/support/commands.js Show resolved Hide resolved
cypress/support/index.js Show resolved Hide resolved
package.json Show resolved Hide resolved
patches/cypress+3.4.1.patch Show resolved Hide resolved
Copy link
Contributor

@spiray spiray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Copy link
Member

@rabbitwerks rabbitwerks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, i trust Josephs judgement, syntax looks good although im not familiar with cypress

@rabbitwerks rabbitwerks merged commit 654bcf1 into develop Sep 6, 2019
@rabbitwerks rabbitwerks deleted the CA-123-testing-setup branch September 6, 2019 04:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants