Split public and private data manager APIs into separate modules #6023
+205
−189
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
instance_name
variable that wasn't part of 3.5's public API (nor were they clearly defined to be part of the public API in 3.4) of thedata_manager
module and supersede it with a publicinstance_name()
function returning the same value_
-prefixed module (basic_config
,basic_config_default
,appdir
,config_dir
load_existing_config()
,config_file
,create_temp_config()
,load_basic_configuration()
have been moved toredbot.core._data_manager
)_base_data_path()
directly todata_path()
and use that everywhere in the module insteadI was also forced to move
cli_level_to_log_level()
from internal utils toredbot.core.cli
due to a circular import. This is a better location for it anyway, especially sinceredbot.core._cli
is now private as well.Have the changes in this PR been tested?
Yes