fix(angular): strip trailing slash from directory nrwl#9263

Coly010 · Mar 14, 2022 · 366f1ee · 366f1ee
1 parent 0d6bdf5
commit 366f1ee
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/packages/angular/src/generators/library/lib/normalize-options.ts b/packages/angular/src/generators/library/lib/normalize-options.ts
@@ -34,7 +34,13 @@ export function normalizeOptions(
 
   const name = names(options.name).fileName;
   const projectDirectory = options.directory
-    ? `${names(options.directory).fileName}/${name}`
+    ? `${
+        names(
+          options.directory.endsWith('/')
+            ? options.directory.slice(0, -1)
+            : options.directory
+        ).fileName
+      }/${name}`
     : name;
 
   const { libsDir, npmScope, standaloneAsDefault } = getWorkspaceLayout(host);

diff --git a/packages/angular/src/generators/library/library.spec.ts b/packages/angular/src/generators/library/library.spec.ts
@@ -46,6 +46,19 @@ describe('lib', () => {
       tree = createTreeWithEmptyWorkspace(2);
     });
 
+    it('should run the library generator without erroring if the directory has a trailing slash', async () => {
+      // ACT
+      let error = null;
+      try {
+        await runLibraryGeneratorWithOpts({ directory: 'mylib/shared/' });
+      } catch (e) {
+        error = e;
+      } finally {
+        // ASSERT
+        expect(error).toBe(null);
+      }
+    });
+
     it('should default to standalone project for first project', async () => {
       await runLibraryGeneratorWithOpts();
       const workspaceJsonEntry = readJson(tree, 'workspace.json').projects[