Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yet Another Fix for RetryWhen #151

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Kn1kt
Copy link

@Kn1kt Kn1kt commented Nov 13, 2022

Continuation of Update testSuccessfulRetry and code to make it pass. #150

First commit

  1. When RetryWhen changes upstream to Sink, the subscription to the previous upstream must be canceled in order not to receive unnecessary events.
  2. You also need to re-request from the new upstream demand, which was not received from the previous upstream.

Second commit

Adds tests for both cases described above

Third commit

Added explicit cancellation of subscriptions in the cancel() method call. Because deinit on Sink can be called after a while, forcing the publisher to work.
This causes a lot of problems when using RetryWhen in cells of collections or tables, where the cancel() method can be called very often and the deinit call on Sink can occur after a few tens of seconds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant