Add overrides to support Infallible #35
Conversation
| var publisher: AnyPublisher<Element, Swift.Never> { | ||
| RxInfalliblePublisher(upstream: self).eraseToAnyPublisher() | ||
| } |
There was a problem hiding this comment.
this is great. Another option could probably just do asPublisher().assertNoFailure("Infallible should not fail") and that way you don't need another custom Publisher type. WDYT?
There was a problem hiding this comment.
Yeah. Could do that too. But RxInfallibleSubscriber already exists so why not use that? Seems a cleaner solution.
Either way. If you prefer assertNoFailure I’ll update to that
There was a problem hiding this comment.
you mean RxInfalliblePublisher ? it didn't exist, you just created it. I'm not keen on adding a new publisher like this because it inherently doesn't "do" anything and we erase the type anyways.
There was a problem hiding this comment.
No, I was referring to RxInfallibleSubscription which does already exist but is not used anywhere.
There was a problem hiding this comment.
Anyway, I've changed it to use assertNoFailure as you suggested
Simplify the code
Adresses issue #34