BlueskyEmbed #1756
Open
BlueskyEmbed #1756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bachbui
reviewed
May 29, 2024
| text: "Lap time al fresco. Photo from my collection, no date/info.[image or embed]— Cats of Yore (@catsofyore.bsky.social) May 14, 2024 at 3:43 PM", | ||
| }) | ||
| ).toMatchInlineSnapshot( | ||
| `"<blockquote class="bluesky-embed" data-bluesky-uri="at://did:plc:xrr5j2okn7ew2zvcwsxus3gb/app.bsky.feed.post/3kshwuxmy5o2y" data-bluesky-cid="bafyreicg7axsdp6b7f4uj75ggdfhrdl52cqpjah45scox3prmqflwg557i">Lap time al fresco. Photo from my collection, no date/info.<br /><br /><a href="https://bsky.app/profile/did:plc:xrr5j2okn7ew2zvcwsxus3gb/post/3kshwuxmy5o2y?ref_src=embed">[image or embed]</a><br />— Cats of Yore (<a href="https://bsky.app/profile/did:plc:xrr5j2okn7ew2zvcwsxus3gb?ref_src=embed">@catsofyore.bsky.social</a>) <a href="https://bsky.app/profile/did:plc:xrr5j2okn7ew2zvcwsxus3gb/post/3kshwuxmy5o2y?ref_src=embed">May 14, 2024 at 3:43 PM</a></blockquote><script async src="https://embed.bsky.app/static/embed.js" charset="utf-8"></script>"` |
bachbui
reviewed
May 29, 2024
| .as("blockquote") | ||
| .outerJoin( | ||
| doc.where({ type: "-html-script" }).as("scripts"), | ||
| function scriptRightAfterIframe(blockquote, script: Script) { |
There was a problem hiding this comment.
minor: the named functions here are nice for our performance tracing, but this kinda suggests we hoist the function definitions up to the top level
There was a problem hiding this comment.
ahh yea, that would make sense to do for these
tim-evans
force-pushed
the
social-media-content
branch
from
cfe433d
to
f88d980
Compare
adds detection of Bluesky embed codes and turns them into embeds. we cannot do URL detection on Bluesky embeds because we need the IPFS cid and uri of the post to properly display it.
this allows for direct linking to the post in cases where user consent was not provided or a web link is wanted
|
@copilot-robot prerelease |
|
Hi, @tim-evans, a pre-release has been published:
|
bachbui
approved these changes
Jun 5, 2024
dkorenblyum
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for detecting and rendering Bluesky posts from HTML. Bluesky's at protocol uses IPFS addressing to identify content, so we need to include both a
uri, and acid, which is the IPFS content id. Aurlis also included so we have a permalink to the post in the case that the post cannot be shown due to user consent not being provided.{ "blocks": [ { "attributes": { "cid": "bafyreicg7axsdp6b7f4uj75ggdfhrdl52cqpjah45scox3prmqflwg557i", "content": "M00000000", "uri": "at://did:plc:xrr5j2okn7ew2zvcwsxus3gb/app.bsky.feed.post/3kshwuxmy5o2y", "url": "https://bsky.app/profile/did:plc:xrr5j2okn7ew2zvcwsxus3gb/post/3kshwuxmy5o2y", }, "id": "B00000000", "parents": [], "selfClosing": false, "type": "bluesky-embed", }, { "attributes": {}, "id": "B00000001", "parents": [ "bluesky-embed", ], "selfClosing": false, "type": "text", }, { "attributes": {}, "id": "B00000002", "parents": [ "bluesky-embed", "text", ], "selfClosing": true, "type": "line-break", }, { "attributes": {}, "id": "B00000003", "parents": [ "bluesky-embed", "text", ], "selfClosing": true, "type": "line-break", }, { "attributes": {}, "id": "B00000004", "parents": [ "bluesky-embed", "text", ], "selfClosing": true, "type": "line-break", }, ], "marks": [ { "attributes": { "refs": [ "B00000000", ], }, "id": "M00000000", "range": "(1..144]", "type": "slice", }, { "attributes": { "url": "https://bsky.app/profile/did:plc:xrr5j2okn7ew2zvcwsxus3gb/post/3kshwuxmy5o2y?ref_src=embed", }, "id": "M00000001", "range": "(63..79)", "type": "link", }, { "attributes": { "url": "https://bsky.app/profile/did:plc:xrr5j2okn7ew2zvcwsxus3gb?ref_src=embed", }, "id": "M00000002", "range": "(96..119)", "type": "link", }, { "attributes": { "url": "https://bsky.app/profile/did:plc:xrr5j2okn7ew2zvcwsxus3gb/post/3kshwuxmy5o2y?ref_src=embed", }, "id": "M00000003", "range": "(121..144)", "type": "link", }, ], "text": "Lap time al fresco. Photo from my collection, no date/info.[image or embed]— Cats of Yore (@catsofyore.bsky.social) May 14, 2024 at 3:43 PM", }