Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor! #58

Closed
wants to merge 108 commits into from
Closed

Editor! #58

wants to merge 108 commits into from

Commits on Apr 17, 2018

  1. fix more edge cases when selecting text

    @tim-evans
    tim-evans authored and Blaine Cook committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    8cd5b02 View commit details
    Browse the repository at this point in the history

  2. allow closures to be called directly from events

    @tim-evans
    tim-evans authored and Blaine Cook committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    baf98c8 View commit details
    Browse the repository at this point in the history

  3. simplify text selection code and make it work with more edge cases 

    Specifically, we have cases where selecting nodes with no children
results in an ambiguous offset. Technically, these represent annotation
boundaries, but since we don't actually want to disambiguate these,
we're instead looking at pure textual offsets.

The major change here was simplifying the code that handles selection
on nodes with no children (cf, <hr>, <img>) and nodes that are outside
the text selection component.
    @tim-evans
    tim-evans authored and Blaine Cook committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    b12393d View commit details
    Browse the repository at this point in the history

  4. add a more complicated document to test text selection better

    @tim-evans
    tim-evans authored and Blaine Cook committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    b0eac84 View commit details
    Browse the repository at this point in the history

  5. move text input management into its own component

    @tim-evans
    tim-evans authored and Blaine Cook committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    a1346d8 View commit details
    Browse the repository at this point in the history

  6. Handle composition events.

    Blaine Cook committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    3bd81bb View commit details
    Browse the repository at this point in the history

  7. Assign detail correctly when dispatching custom events

    Blaine Cook committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    4687554 View commit details
    Browse the repository at this point in the history

  8. Handle bold/italic format input events.

    Blaine Cook committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    c3db515 View commit details
    Browse the repository at this point in the history

  9. factor out reset-text-nodes for reuse

    Blaine Cook committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    5206af5 View commit details
    Browse the repository at this point in the history

  10. add setSelection method to enable resetting of the selection when we … 

    …have lost the original DOM tree / selection
    Blaine Cook committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    9cd9b7b View commit details
    Browse the repository at this point in the history

  11. handle the insertion / deletion of text and insertion of annotations … 

    …(deletion/update of annotations TK)
    Blaine Cook committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    245e17e View commit details
    Browse the repository at this point in the history

  12. Add pre-wrap styling to editor to preserve whitespace.

    Blaine Cook committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    d80e793 View commit details
    Browse the repository at this point in the history

  13. Add some debugging and start on WIP for paragraph handling.

    Blaine Cook committed Apr 17, 2018
    Configuration menu
    Copy the full SHA
    9d1b9ce View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2018

  1. fix more edge cases when selecting text

    @tim-evans
    tim-evans authored and Blaine Cook committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    01623d9 View commit details
    Browse the repository at this point in the history

  2. allow closures to be called directly from events

    @tim-evans
    tim-evans authored and Blaine Cook committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    2b9cb88 View commit details
    Browse the repository at this point in the history

  3. simplify text selection code and make it work with more edge cases 

    Specifically, we have cases where selecting nodes with no children
results in an ambiguous offset. Technically, these represent annotation
boundaries, but since we don't actually want to disambiguate these,
we're instead looking at pure textual offsets.

The major change here was simplifying the code that handles selection
on nodes with no children (cf, <hr>, <img>) and nodes that are outside
the text selection component.
    @tim-evans
    tim-evans authored and Blaine Cook committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    499124b View commit details
    Browse the repository at this point in the history

  4. add a more complicated document to test text selection better

    @tim-evans
    tim-evans authored and Blaine Cook committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    7d38eaa View commit details
    Browse the repository at this point in the history

  5. move text input management into its own component

    @tim-evans
    tim-evans authored and Blaine Cook committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    fc64db4 View commit details
    Browse the repository at this point in the history

  6. Handle composition events.

    Blaine Cook committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    ded75d0 View commit details
    Browse the repository at this point in the history

  7. Assign detail correctly when dispatching custom events

    Blaine Cook committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    0257ad1 View commit details
    Browse the repository at this point in the history

  8. Handle bold/italic format input events.

    Blaine Cook committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    8f37128 View commit details
    Browse the repository at this point in the history

  9. factor out reset-text-nodes for reuse

    Blaine Cook committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    ff60b69 View commit details
    Browse the repository at this point in the history

  10. add setSelection method to enable resetting of the selection when we … 

    …have lost the original DOM tree / selection
    Blaine Cook committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    b19e112 View commit details
    Browse the repository at this point in the history

  11. handle the insertion / deletion of text and insertion of annotations … 

    …(deletion/update of annotations TK)
    Blaine Cook committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    098129c View commit details
    Browse the repository at this point in the history

  12. Add pre-wrap styling to editor to preserve whitespace.

    Blaine Cook committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    9730aaf View commit details
    Browse the repository at this point in the history

  13. Add some debugging and start on WIP for paragraph handling.

    Blaine Cook committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    1c2c691 View commit details
    Browse the repository at this point in the history

  14. Merge branch 'editor' of github.com:CondeNast-Copilot/atjson into editor

    Blaine Cook committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    26a6e7f View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2018

  1. Fixes for basic demo

    Blaine Cook committed Apr 20, 2018
    Configuration menu
    Copy the full SHA
    4060fb7 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2018

  1. wip rebase

    Blaine Cook committed May 5, 2018
    Configuration menu
    Copy the full SHA
    4703529 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2018

  1. Merge branch 'latest' into editor

    Blaine Cook committed Jun 6, 2018
    Configuration menu
    Copy the full SHA
    c174e63 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2018

  1. broken wip

    Blaine Cook committed Jun 7, 2018
    Configuration menu
    Copy the full SHA
    96f222a View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2018

  1. add very primitive change event to document

    Blaine Cook committed Jun 9, 2018
    Configuration menu
    Copy the full SHA
    b17cce8 View commit details
    Browse the repository at this point in the history

  2. Refactor so that standalone editor is a standalone component and demo… 

    …/dingus is separate and uses the base editor separately.
    Blaine Cook committed Jun 9, 2018
    Configuration menu
    Copy the full SHA
    f33a066 View commit details
    Browse the repository at this point in the history

  3. handle inversion / overlaps of inline singleton annotations

    Blaine Cook committed Jun 9, 2018
    Configuration menu
    Copy the full SHA
    99e6232 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2018

  1. Move Webcomponent Renderer to separate directory

    Blaine Cook committed Jun 21, 2018
    Configuration menu
    Copy the full SHA
    66500a2 View commit details
    Browse the repository at this point in the history

  2. Move demo and inspector to separate directory

    Blaine Cook committed Jun 21, 2018
    Configuration menu
    Copy the full SHA
    1e37da4 View commit details
    Browse the repository at this point in the history

  3. Remove (currently unsupported) second paragraph from demo

    Blaine Cook committed Jun 21, 2018
    Configuration menu
    Copy the full SHA
    2ed71a5 View commit details
    Browse the repository at this point in the history

  4. Automatically descend to shadowRoot. Not sure if this is a good idea.

    Blaine Cook committed Jun 21, 2018
    Configuration menu
    Copy the full SHA
    1b7a936 View commit details
    Browse the repository at this point in the history

  5. update and pin parcel-bundler; 1.9.x seems broken

    Blaine Cook committed Jun 21, 2018
    Configuration menu
    Copy the full SHA
    5728e94 View commit details
    Browse the repository at this point in the history

  6. include web component base as a mixin

    Blaine Cook committed Jun 21, 2018
    Configuration menu
    Copy the full SHA
    efe16bd View commit details
    Browse the repository at this point in the history

  7. add support (and make explicit non-support) for various other input e… 

    …vents
    Blaine Cook committed Jun 21, 2018
    Configuration menu
    Copy the full SHA
    dc03b11 View commit details
    Browse the repository at this point in the history

  8. add toolbar that maps to selections

    Blaine Cook committed Jun 21, 2018
    Configuration menu
    Copy the full SHA
    3e1182e View commit details
    Browse the repository at this point in the history

  9. handle the dom being a bit pants

    Blaine Cook committed Jun 21, 2018
    Configuration menu
    Copy the full SHA
    f51169f View commit details
    Browse the repository at this point in the history

  10. bugfixes; need more investigation

    Blaine Cook committed Jun 21, 2018
    Configuration menu
    Copy the full SHA
    54fb7a4 View commit details
    Browse the repository at this point in the history

  11. add caret focus events in order to activate web components that exist… 

    … at the caret
    Blaine Cook committed Jun 21, 2018
    Configuration menu
    Copy the full SHA
    7694679 View commit details
    Browse the repository at this point in the history

  12. add event to track annotation changes

    Blaine Cook committed Jun 21, 2018
    Configuration menu
    Copy the full SHA
    7873681 View commit details
    Browse the repository at this point in the history

  13. add link annotation to default demo doc

    Blaine Cook committed Jun 21, 2018
    Configuration menu
    Copy the full SHA
    6a7c8a4 View commit details
    Browse the repository at this point in the history

  14. add commonmark renderer dep

    Blaine Cook committed Jun 21, 2018
    Configuration menu
    Copy the full SHA
    a6ce2be View commit details
    Browse the repository at this point in the history

  15. Fix change tracking for documents

    Blaine Cook committed Jun 21, 2018
    Configuration menu
    Copy the full SHA
    0014b05 View commit details
    Browse the repository at this point in the history

  16. add support for passing ids into hir/json nodes in order to have anno… 

    …tation id pass through to rendered doc.
    Blaine Cook committed Jun 21, 2018
    Configuration menu
    Copy the full SHA
    3a6c6eb View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2018

  1. set commonmark renderer version

    Blaine Cook committed Jun 27, 2018
    Configuration menu
    Copy the full SHA
    1d66e2c View commit details
    Browse the repository at this point in the history

  2. Refactor editable components for less boilerplate.

    Blaine Cook committed Jun 27, 2018
    Configuration menu
    Copy the full SHA
    533f684 View commit details
    Browse the repository at this point in the history

  3. tweak logo

    Blaine Cook committed Jun 27, 2018
    Configuration menu
    Copy the full SHA
    1226b64 View commit details
    Browse the repository at this point in the history

  4. move logo to components

    Blaine Cook committed Jun 27, 2018
    Configuration menu
    Copy the full SHA
    4b56a7f View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2018

  1. a few visual tweaks

    Blaine Cook committed Jul 11, 2018
    Configuration menu
    Copy the full SHA
    36eab12 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'latest' into editor

    Blaine Cook committed Jul 11, 2018
    Configuration menu
    Copy the full SHA
    12e46c3 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2018

  1. Don't redeclare loop variable. Oops.

    @blaine
    blaine committed Jul 13, 2018
    Configuration menu
    Copy the full SHA
    fcbdd6b View commit details
    Browse the repository at this point in the history

  2. Add a touch of documentation

    @blaine
    blaine committed Jul 13, 2018
    Configuration menu
    Copy the full SHA
    9c3186e View commit details
    Browse the repository at this point in the history

  3. Miscellaneous cleanup (debugging, indentation, etc)

    @blaine
    blaine committed Jul 13, 2018
    Configuration menu
    Copy the full SHA
    00186cd View commit details
    Browse the repository at this point in the history

  4. Delete unused webcomponent renderer, pending proper extraction from e… 

    …ditor.
    @blaine
    blaine committed Jul 13, 2018
    Configuration menu
    Copy the full SHA
    069d576 View commit details
    Browse the repository at this point in the history

  5. Remove unused code

    @blaine
    blaine committed Jul 13, 2018
    Configuration menu
    Copy the full SHA
    9f1c406 View commit details
    Browse the repository at this point in the history

  6. Fix paragraph insertion.

    @blaine
    blaine committed Jul 13, 2018
    Configuration menu
    Copy the full SHA
    2512639 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2018

  1. Cleanup

    @blaine
    blaine committed Jul 16, 2018
    Configuration menu
    Copy the full SHA
    1ed8c1e View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2018

  1. tslint cleanups

    @blaine
    blaine committed Jul 17, 2018
    Configuration menu
    Copy the full SHA
    451e5b9 View commit details
    Browse the repository at this point in the history

  2. Big reorg; move everything out of src except core bits, move webcompo… 

    …nent renderer to separate lib.
    @blaine
    blaine committed Jul 17, 2018
    Configuration menu
    Copy the full SHA
    ee6529d View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2018

  1. Incr parcel version

    @blaine
    blaine committed Jul 18, 2018
    Configuration menu
    Copy the full SHA
    c6980d3 View commit details
    Browse the repository at this point in the history

  2. Update method for importing web components, s/text-editor/offset-editor/

    @blaine
    blaine committed Jul 18, 2018
    Configuration menu
    Copy the full SHA
    10459fa View commit details
    Browse the repository at this point in the history

  3. renderer-webcomponent: Address TypeScript compiler warnings.

    @foobarrio @blaine
    foobarrio authored and blaine committed Jul 18, 2018
    Configuration menu
    Copy the full SHA
    2ff7de7 View commit details
    Browse the repository at this point in the history

  4. Components!!!

    @blaine
    blaine authored and Blaine Cook committed Jul 18, 2018
    Configuration menu
    Copy the full SHA
    be85c78 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2018

  1. Contextual Heading Button (prototype for button interactions)

    @blaine
    blaine committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    14a3f66 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2018

  1. Fix positioning of toolbar

    @blaine
    blaine committed Jul 20, 2018
    Configuration menu
    Copy the full SHA
    52ba1dc View commit details
    Browse the repository at this point in the history

  2. Reduce agressiveness / debounce toolbar and cursor focus events

    @blaine
    blaine committed Jul 20, 2018
    Configuration menu
    Copy the full SHA
    0b18348 View commit details
    Browse the repository at this point in the history

  3. Remove debug logging

    @blaine
    blaine committed Jul 20, 2018
    Configuration menu
    Copy the full SHA
    871f070 View commit details
    Browse the repository at this point in the history

  4. Actually fix toolbar positioning

    @blaine
    blaine committed Jul 20, 2018
    Configuration menu
    Copy the full SHA
    b138162 View commit details
    Browse the repository at this point in the history

  5. Convert removed headings to paragraphs.

    @blaine
    blaine committed Jul 20, 2018
    Configuration menu
    Copy the full SHA
    0b1cc4e View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2018

  1. 👩‍⚕️🐛 Switch to bubbling, don't observe event directly (allows for ev… 

    …ents from e.g., toolbar).
    Blaine Cook committed Jul 23, 2018
    Configuration menu
    Copy the full SHA
    5693613 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2018

  1. refactor: move inspector to separate package

    Blaine Cook committed Jul 30, 2018
    Configuration menu
    Copy the full SHA
    e61ac0c View commit details
    Browse the repository at this point in the history

  2. move core web components to separate package

    Blaine Cook committed Jul 30, 2018
    Configuration menu
    Copy the full SHA
    abf0376 View commit details
    Browse the repository at this point in the history

  3. always build tsc package

    Blaine Cook committed Jul 30, 2018
    Configuration menu
    Copy the full SHA
    0f02fee View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2018

  1. Add jenkinsfile

    @blaine
    blaine committed Aug 3, 2018
    Configuration menu
    Copy the full SHA
    2f44f4d View commit details
    Browse the repository at this point in the history

  2. Always build

    @blaine
    blaine committed Aug 3, 2018
    Configuration menu
    Copy the full SHA
    3992067 View commit details
    Browse the repository at this point in the history

  3. block transform tweaks

    Blaine Cook committed Aug 3, 2018
    Configuration menu
    Copy the full SHA
    9d0ebdc View commit details
    Browse the repository at this point in the history

  4. Merge branch 'latest' into editor

    @blaine
    blaine committed Aug 3, 2018
    Configuration menu
    Copy the full SHA
    fa83a1e View commit details
    Browse the repository at this point in the history

  5. Fix package.json merge typo

    @blaine
    blaine committed Aug 3, 2018
    Configuration menu
    Copy the full SHA
    903f2a3 View commit details
    Browse the repository at this point in the history

  6. always build

    Blaine Cook committed Aug 3, 2018
    Configuration menu
    Copy the full SHA
    e118172 View commit details
    Browse the repository at this point in the history

  7. ugh, fix package.json hell

    Blaine Cook committed Aug 3, 2018
    Configuration menu
    Copy the full SHA
    4092c95 View commit details
    Browse the repository at this point in the history

  8. Add index.js for Departures (run offset inspector)

    Blaine Cook committed Aug 3, 2018
    Configuration menu
    Copy the full SHA
    cb6c29b View commit details
    Browse the repository at this point in the history

  9. re-add parcel-bundler to offset-inspector

    Blaine Cook committed Aug 3, 2018
    Configuration menu
    Copy the full SHA
    61151a9 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2018

  1. Adjust build scripts so that lerna build will always succeed, even wi… 

    …th local failures
    Blaine Cook committed Aug 6, 2018
    Configuration menu
    Copy the full SHA
    d4e5b37 View commit details
    Browse the repository at this point in the history

  2. make build work for departures, hopefully

    Blaine Cook committed Aug 6, 2018
    Configuration menu
    Copy the full SHA
    498f61d View commit details
    Browse the repository at this point in the history

  3. move parcel to full dep because departures strips dev deps

    Blaine Cook committed Aug 6, 2018
    Configuration menu
    Copy the full SHA
    3e2b562 View commit details
    Browse the repository at this point in the history

  4. Ugh, do not want to add this here, but might be necessary for departu… 

    …res.
    Blaine Cook committed Aug 6, 2018
    Configuration menu
    Copy the full SHA
    2f657bb View commit details
    Browse the repository at this point in the history

  5. Try without hoisting?

    Blaine Cook committed Aug 6, 2018
    Configuration menu
    Copy the full SHA
    9235cc9 View commit details
    Browse the repository at this point in the history

  6. debugging

    Blaine Cook committed Aug 6, 2018
    Configuration menu
    Copy the full SHA
    44b0de7 View commit details
    Browse the repository at this point in the history

  7. giving up. switching to a local server. shrug.

    Blaine Cook committed Aug 6, 2018
    Configuration menu
    Copy the full SHA
    c07ae74 View commit details
    Browse the repository at this point in the history

  8. Fix ts issues

    Blaine Cook committed Aug 6, 2018
    Configuration menu
    Copy the full SHA
    c10ef64 View commit details
    Browse the repository at this point in the history

  9. cleanup tsc errors

    Blaine Cook committed Aug 6, 2018
    Configuration menu
    Copy the full SHA
    543a0f4 View commit details
    Browse the repository at this point in the history

  10. more tsc cleanup

    Blaine Cook committed Aug 6, 2018
    Configuration menu
    Copy the full SHA
    82e470c View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2018

  1. Update to latest @atjson/document in renderer-commonmark and renderer… 

    …-hir.
    @foobarrio @blaine
    foobarrio authored and blaine committed Aug 8, 2018
    Configuration menu
    Copy the full SHA
    fc7689d View commit details
    Browse the repository at this point in the history

  2. offset-core-components: Override shadowRoot to not allow null.

    @foobarrio @blaine
    foobarrio authored and blaine committed Aug 8, 2018
    Configuration menu
    Copy the full SHA
    d60ccf2 View commit details
    Browse the repository at this point in the history

  3. Don't bump @atjson/document version (Lerna will handle it).

    @foobarrio @blaine
    foobarrio authored and blaine committed Aug 8, 2018
    Configuration menu
    Copy the full SHA
    9ca5c5d View commit details
    Browse the repository at this point in the history

  4. Extend root tsconfig.json and use tsconfig when invoking tslint.

    @foobarrio @blaine
    foobarrio authored and blaine committed Aug 8, 2018
    Configuration menu
    Copy the full SHA
    31ab164 View commit details
    Browse the repository at this point in the history

  5. Alphabetize tsconfig.json entries.

    @foobarrio @blaine
    foobarrio authored and blaine committed Aug 8, 2018
    Configuration menu
    Copy the full SHA
    189d37d View commit details
    Browse the repository at this point in the history

  6. offset-core-components: Revert acccessing of compiledTemplate.

    @foobarrio @blaine
    foobarrio authored and blaine committed Aug 8, 2018
    Configuration menu
    Copy the full SHA
    deb5a88 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2018

  1. Move events to named functions

    Blaine Cook committed Aug 31, 2018
    Configuration menu
    Copy the full SHA
    dece44d View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2018

  1. Tweaks to improve dramatically improve performance of inspector.

    Blaine Cook committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    b4bf287 View commit details
    Browse the repository at this point in the history

  2. tiny cleanup

    Blaine Cook committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    d22c5f7 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2018

  1. 🛀 Add non-emitting tsconfig.json to editor/test. (#79) 

    This sets a TypeScript compilation context for ts files in test/ allowing VSCode (among other editors) to surface TypeScript errors.
    @foobarrio
    foobarrio committed Sep 7, 2018
    Configuration menu
    Copy the full SHA
    2bdabc9 View commit details
    Browse the repository at this point in the history