Use cpluginv2 and conduit commons #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 14, 2024
lovromazgon
commented
May 23, 2024
|
|
||
| // TODO should we stop doing this here? The Processor SDK does NOT do this. |
There was a problem hiding this comment.
This is actually addressed in #133.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR updates the connector protocol to the latest code in
main(we need to bump the version before releasing).Additionally, it removes the internal
Recordtype and everything related to it (structured data, raw data, metadata, serializers etc.) in favor of theopencdc.Recordtype in conduit-commons. It also removesValidationin favor ofconfig.Validationin conduit-commons.Depends on ConduitIO/conduit-connector-protocol#90.Merged.Part of ConduitIO/conduit#1433.
Quick checks:
update/change.