Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema support (design doc) #1532

Merged
merged 51 commits into from
May 29, 2024
Merged

Schema support (design doc) #1532

merged 51 commits into from
May 29, 2024

Conversation

hariso
Copy link
Contributor

@hariso hariso commented May 2, 2024

Description

This PR documents the design for Conduit's support for schemas. A few questions are still open, and, from that point, the design is not completely done.

Quick checks:

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@hariso hariso marked this pull request as ready for review May 6, 2024 10:43
@hariso hariso requested a review from a team as a code owner May 6, 2024 10:43
docs/design-documents/20240430-schema-support.md Outdated Show resolved Hide resolved
docs/design-documents/20240430-schema-support.md Outdated Show resolved Hide resolved
docs/design-documents/20240430-schema-support.md Outdated Show resolved Hide resolved
docs/design-documents/20240430-schema-support.md Outdated Show resolved Hide resolved
docs/design-documents/20240430-schema-support.md Outdated Show resolved Hide resolved
docs/design-documents/20240430-schema-support.md Outdated Show resolved Hide resolved
docs/design-documents/20240430-schema-support.md Outdated Show resolved Hide resolved
docs/design-documents/20240430-schema-support.md Outdated Show resolved Hide resolved
hariso and others added 10 commits May 17, 2024 11:18
Co-authored-by: Raúl Barroso <ra.barroso@gmail.com>
Co-authored-by: Raúl Barroso <ra.barroso@gmail.com>
Co-authored-by: Raúl Barroso <ra.barroso@gmail.com>
Co-authored-by: Raúl Barroso <ra.barroso@gmail.com>
Co-authored-by: Raúl Barroso <ra.barroso@gmail.com>
Co-authored-by: Raúl Barroso <ra.barroso@gmail.com>
Co-authored-by: Raúl Barroso <ra.barroso@gmail.com>
Copy link
Member

@lovromazgon lovromazgon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last nitpick, LGTM 👍

Copy link
Member

@raulb raulb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hariso I only left one comment regarding Schema structure. Everything else looks great! Thanks for working on this.

@raulb
Copy link
Member

raulb commented May 23, 2024

@hariso github is not showing accordingly what this comment is about. For reference, it's in response to your comment here.

@hariso hariso enabled auto-merge (squash) May 28, 2024 11:39
@hariso hariso merged commit b6f3b46 into main May 29, 2024
4 checks passed
@hariso hariso deleted the haris/schema-support branch May 29, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants