Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4 API: Use OAuth instead of API Key and Secret #652

Open
wants to merge 97 commits into
base: main
Choose a base branch
from

Conversation

n7studios
Copy link
Contributor

@n7studios n7studios commented Apr 23, 2024

Summary

Replaces the API Key and Secret fields with the OAuth flow using the v4 API at Settings > ConvertKit, using the v4 API library implementation for API requests.

Before:
Screenshot 2024-05-13 at 10 18 07

After:
Screenshot 2024-05-13 at 10 19 13

Screenshot 2024-05-13 at 10 16 45

Video:
https://www.loom.com/share/e5f412bbf9954bb6bbd8ad367a4ce20f?sid=2cd70890-aadb-4faf-9d1b-bc0d8ae2e804

Testing

Some tests will currently fail due to changes in the UI for OAuth, Setup Wizard and Legacy Forms / Landing Pages.

Further PR's submitted for ease of review to cover these separately:

With those PR's merged, tests here must then pass.

Checklist

@n7studios n7studios added this to the 2.5.0 milestone Apr 23, 2024
@n7studios n7studios self-assigned this Apr 23, 2024
@n7studios n7studios requested review from a team, noelherrick and jenessawhite and removed request for a team May 14, 2024 13:45
@n7studios n7studios marked this pull request as ready for review May 14, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants