-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v4 API: Use OAuth instead of API Key and Secret #652
Open
n7studios
wants to merge
97
commits into
main
Choose a base branch
from
v4-api-oauth
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
…hout changing a default form
…exchange-key-for-token
…oauth-exchange-key-for-token
# Conflicts: # wp-convertkit.php
…oauth-exchange-key-for-token
…oauth-exchange-key-for-token
n7studios
requested review from
a team,
noelherrick and
jenessawhite
and removed request for
a team
May 14, 2024 13:45
noelherrick
approved these changes
May 15, 2024
…-token v4 API: Exchange API Key and Secret for Access and Refresh Tokens on Plugin Upgrade
v4 API: Tests: Use OAuth instead of API Key and Secret
v4 API: Improve Disconnect
jenessawhite
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the API Key and Secret fields with the OAuth flow using the v4 API at
Settings > ConvertKit
, using the v4 API library implementation for API requests.Before:
After:
Video:
https://www.loom.com/share/e5f412bbf9954bb6bbd8ad367a4ce20f?sid=2cd70890-aadb-4faf-9d1b-bc0d8ae2e804
Testing
Some tests will currently fail due to changes in the UI for OAuth, Setup Wizard and Legacy Forms / Landing Pages.
Further PR's submitted for ease of review to cover these separately:
With those PR's merged, tests here must then pass.
Checklist