Merge changes and ideas from Arnold and Alsong #332
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @arnoldmukisa @alsong,
We recently moved
messages
to the global context, just in a slightly different way :) This PR merges the existing approach with your PR.Also nice idea loading/restoring the message history from local storage! Since our users might have different strategies on storing the message history, I cannot enable this for all users. However, since we now gained the capability to access the messages array from the context object, it is now very simple to just load the messages in application code.
I added this as an example to the presentation code.