Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #86: ECDHE with ASIO (w/ pull request #117) #90

Open
wants to merge 2 commits into
base: 4.7
Choose a base branch
from

Conversation

conz27
Copy link

@conz27 conz27 commented Apr 25, 2016

Implements ECDHE support in RestBed, but requires the version of ASIO that incorporates: chriskohlhoff/asio#117

Might be a bit until that happens; but the change is here none the less.

In the mean time, you may be able to cherry-pick 0903c62, which implements a proof-of-concept version hardcoded to work with secp256r1 (P-256 curve).

Fixes #86.

Constantine Grantcharov and others added 2 commits April 25, 2016 01:04
- this is just a stop-gap change until this is implemented in
Boost::ASIO

- enables passing EDCH temporary parameters needed for Ephemeral Diffie-
Hellman, which enables Perfect Forward Secrecy in the HTTPS server
- implemented ECDHE support in restbed to work with the patched ASIO
implementation from chriskohlhoff/asio#117

- if the patch is pulled into Corusoft's repository, ASIO will work with
the current version of ASIO; remove #ifdef ECDHE_SUPPORT if that
happens.
@conz27 conz27 changed the title ECDHE with ASIO (pull request #117) Fix #90: ECDHE with ASIO (w/ pull request #117) Apr 25, 2016
@conz27 conz27 changed the title Fix #90: ECDHE with ASIO (w/ pull request #117) Fix #86: ECDHE with ASIO (w/ pull request #117) Apr 25, 2016
@ben-crowhurst ben-crowhurst added this to the 4.5 milestone Apr 26, 2016
@ben-crowhurst
Copy link
Member

ben-crowhurst commented Sep 7, 2016

How will the upgrade to the latest OpenSSL 102 effect this PR, if at all?

@conz27
Copy link
Author

conz27 commented Sep 7, 2016

@ben-crowhurst: will have to investigate the API for OpenSSL 1.0.2 and let you know.

But you need to check to see if FIPS140.2 support is necessary for your project because I don't think the OpenSSL v1.0.2 has achieved certification yet. In a nutshell, newest isn't always best depending on requirements.

@ben-crowhurst
Copy link
Member

ben-crowhurst commented Sep 7, 2016

Can migrate to OpenSSL-fips-2_0-stable under your recommendation?

@conz27
Copy link
Author

conz27 commented Sep 7, 2016

OpenSSL recommends the 2.0.9 branch https://github.com/openssl/openssl/releases/tag/OpenSSL-fips-2_0_9 - found it here: https://www.openssl.org/docs/fips.html.

According the OpenSSL, there is a very specific set of steps required to compile the library for FIPS140-2 support. Need to make sure your project does it exactly as specified for it to be valid; if you deviate from the process at all, it will require re-validation.

@ben-crowhurst ben-crowhurst modified the milestone: 4.5 Nov 4, 2016
@ben-crowhurst ben-crowhurst added this to the 4.7 milestone Feb 8, 2020
@ben-crowhurst ben-crowhurst added this to To do in Restbed via automation Feb 8, 2020
@ben-crowhurst ben-crowhurst self-requested a review February 8, 2020 06:44
@ben-crowhurst ben-crowhurst changed the base branch from master to 4.7 February 15, 2020 22:10
@ben-crowhurst ben-crowhurst modified the milestones: 4.7, 4.8 Jan 2, 2021
@ben-crowhurst ben-crowhurst modified the milestones: 4.8, 4.9 Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Restbed
  
To do
Development

Successfully merging this pull request may close these issues.

Unable to use ECDHE-ECDSA-AES128-SHA256 cipher suite with Restbed
2 participants