Frontend/chore/typecheck unit tests #1062
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that I didn't want to add it to "test" script (like I've done with the "test-ci" script) since it would only run tsc the first. When no typescript errors are found, jest will start in watch mode. This means that ff you would cause new typescript errors after the initial "yarn test" they would go unnoticed. I'm not sure if there is a nice way at the moment to use 'react-scripts test' and have tests fail if they contain typescript errors. 'ts-jest' is an alternative which does do typechecking for tests. However I'm uncertain if that's what we want to use.
This allows to run tsc locally using typescript version from node_modules folder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the typescript errors in tests and changed the
test-ciscript so that CI pipeling fails if tests have typescript errors.This PR has no affect when running
yarn testlocally.Adding
tscto thetestscript as suggested in facebook/create-react-app#5626 will not fully work withreact-scripts testand might cause frustration if you have to wait for the entire source code to be typechecked by tsc when you just want to run a single test. Also it would only run tsc a single time. If no typescript errors have been detected, jest will start in watch mode. Meaning that typescript errors added while test script is already running (and watching for file changes) will still go unnoticed.I've added
tscas stand alone script so developers can run it locally withyarn tscas a temporary help to check all files for typescript errors.#851