Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing IPO to the CMake build process. #951

Draft
wants to merge 8 commits into
base: development
Choose a base branch
from
Draft

Conversation

tcormackMW
Copy link
Contributor

Performance verified locally: does not seem to be causing regressions consistently... subject to consistency of local machine.

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #951 (14a9fcf) into development (bce4a3e) will decrease coverage by 0.07%.
Report is 2 commits behind head on development.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #951      +/-   ##
===============================================
- Coverage        88.62%   88.56%   -0.07%     
===============================================
  Files              221      219       -2     
  Lines            13130    12405     -725     
===============================================
- Hits             11637    10986     -651     
+ Misses            1493     1419      -74     

see 96 files with indirect coverage changes

Copy link
Member

@jeffdiclemente jeffdiclemente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary to call set_property(TARGET ${us_configurationadmin_test_exe_name} PROPERTY INTERPROCEDURAL_OPTIMIZATION ${CMAKE_ENABLE_LTO}) in each CMakeLists.txt file? Can CMAKE_INTERPROCEDURAL_OPTIMIZATION be used to set this property once and have it used for all targets?

CMakeLists.txt Outdated Show resolved Hide resolved
@tcormackMW tcormackMW marked this pull request as draft November 3, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants