Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix WC issue #439

Merged
merged 1 commit into from
Mar 19, 2024
Merged

fix WC issue #439

merged 1 commit into from
Mar 19, 2024

Conversation

MatiNavCrossmint
Copy link
Contributor

Description

In the WC build, we're having this error:

Error: src/wallets/WalletConnectEVMAAWallet.ts(9,5): error TS2742: The inferred type of 'getSupportedChains' cannot be named without a reference to '@crossmint/client-sdk-aa/node_modules/@crossmint/common-sdk-base'. This is likely not portable. A type annotation is necessary.

It looks like a bug from Typescript (that comment is from last week).
How it applies to our situation:

// Base

export { BlockchainIncludingTestnet }

// AA

import { BlockchainIncludingTestnet }
...
export { EVMAAWallet } from  'Base'

// WC SDK

import { EVMAAWallet } from 'AA' // => uses BlockchainIncludingTestnet from Base
..
import { BlockchainIncludingTestnet } from 'Base'

This final situation on WC SDK is the cause of the error

Test plan

We need to deploy and release a new version, and then check if when importing that new version this gets fixed.

Copy link

changeset-bot bot commented Mar 18, 2024

⚠️ No Changeset found

Latest commit: 1f2cd96

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@afeight afeight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@afeight afeight merged commit 8662710 into main Mar 19, 2024
1 check passed
@afeight afeight deleted the matias/AA/scw-101-wc-astar-demo branch March 19, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants