Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Pin to pnpm 7.30.0 as 7.30.1 breaks tests #103

Closed
wants to merge 1 commit into from

Conversation

ynotdraw
Copy link
Contributor

@ynotdraw ynotdraw commented Mar 23, 2023

I was hitting an issue in ember-toucan-core on main where we were getting what is described in embroider-build/embroider#1378. I ended up creating a branch here to see if ember-headless-form was also hitting it and sure enough it was (see: #102 - this PR was branched off of main).

This temporarily pins the version of pnpm used so that the embroider steps no longer fail as shown by https://github.com/CrowdStrike/ember-headless-form/actions/runs/4501225556/jobs/7921393859.

We should probably file something with pnpm on this, or who knows, maybe it'll be resolved come Monday?

related: CrowdStrike/ember-toucan-core#99
related 2: pnpm/pnpm#6271

@changeset-bot
Copy link

changeset-bot bot commented Mar 23, 2023

⚠️ No Changeset found

Latest commit: a31a970

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

Preview URLs

Env: preview
Docs: https://115ba04b.ember-headless-form.pages.dev

@ynotdraw ynotdraw marked this pull request as ready for review March 23, 2023 18:03
@ynotdraw
Copy link
Contributor Author

Going to go ahead and close as this should now work with v7.30.3-0 pnpm/pnpm#6271 (comment)

@ynotdraw ynotdraw closed this Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants