Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dependenciesMeta.*.injected, fix peer deps #49

Merged
merged 2 commits into from
Feb 15, 2023
Merged

Add dependenciesMeta.*.injected, fix peer deps #49

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54308b3
Add `dependenciesMeta.*.injected`, fix peer deps
simonihmig Feb 15, 2023
e988c6d
Fix peer dep for min. supported Ember
simonihmig Feb 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/changeset-validations/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@
"peerDependencies": {
"validated-changeset": "^1.3.4",
"ember-changeset": "^4.1.2",
"ember-headless-form": "^0.0.0"
"ember-headless-form": "^0.0.0",
"ember-source": "^4.8.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the min version 4.4 or 4.8?

The try config has 4.4. last i looked, but if 4.8 is min required, then we can remove the function polyfill 🎉

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, good catch. Yeah, I still have 4.4, that's why the polyfill was added. Accidental copy-paste error, will fix!

},
"devDependencies": {
"@babel/core": "^7.17.0",
Expand Down Expand Up @@ -67,6 +68,7 @@
"ember-changeset": "^4.0.0",
"ember-headless-form": "workspace:*",
"ember-template-lint": "^4.0.0",
"ember-source": "~4.10.0",
"eslint": "^7.32.0",
"eslint-config-prettier": "^8.3.0",
"eslint-plugin-ember": "^10.5.8",
Expand Down
4 changes: 3 additions & 1 deletion packages/ember-headless-form/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@
},
"peerDependencies": {
"@glimmer/component": "^1.1.2",
"@glimmer/tracking": "^1.1.2"
"@glimmer/tracking": "^1.1.2",
"ember-source": "^4.8.0"
},
"devDependencies": {
"@babel/core": "^7.17.0",
Expand Down Expand Up @@ -74,6 +75,7 @@
"@typescript-eslint/eslint-plugin": "^5.30.5",
"@typescript-eslint/parser": "^5.30.5",
"concurrently": "^7.2.1",
"ember-source": "~4.10.0",
"ember-template-lint": "^4.0.0",
"eslint": "^7.32.0",
"eslint-config-prettier": "^8.3.0",
Expand Down
4 changes: 3 additions & 1 deletion packages/yup/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@
},
"peerDependencies": {
"yup": "^1.0.0",
"ember-headless-form": "^0.0.0"
"ember-headless-form": "^0.0.0",
"ember-source": "^4.8.0"
},
"devDependencies": {
"@babel/core": "^7.17.0",
Expand Down Expand Up @@ -66,6 +67,7 @@
"concurrently": "^7.2.1",
"ember-headless-form": "workspace:*",
"ember-template-lint": "^4.0.0",
"ember-source": "~4.10.0",
"eslint": "^7.32.0",
"eslint-config-prettier": "^8.3.0",
"eslint-plugin-ember": "^10.5.8",
Expand Down