Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pnpm i -f must be ran after a build, when using depMea.*.injected #51

Merged
merged 1 commit into from Feb 15, 2023

Conversation

NullVoxPopuli
Copy link
Contributor

@NullVoxPopuli NullVoxPopuli commented Feb 15, 2023

due to #49 (comment),
#45 is no longer viable.

See: pnpm/pnpm#6088

@changeset-bot
Copy link

changeset-bot bot commented Feb 15, 2023

⚠️ No Changeset found

Latest commit: 44895c9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@NullVoxPopuli NullVoxPopuli marked this pull request as ready for review February 15, 2023 19:00
@simonihmig
Copy link
Contributor

Ok, I could have done that as part of #49. But I thought we would be able to land #45...

This is not feasible currently, as the build step triggered by turbo would need to also have pnpm i -f. But still theoretically we could do this? It is just too costly here? More costly than what we have with this PR?

@simonihmig simonihmig merged commit 4a17863 into main Feb 15, 2023
@simonihmig simonihmig deleted the fix-ci branch February 15, 2023 19:08
@NullVoxPopuli
Copy link
Contributor Author

But still theoretically we could do this?

I don't think it's possible -- I opened an issue with turbo here: vercel/turbo#2306 and we tried some solutions, but ultimately, we need to solve: pnpm/pnpm#6088

@simonihmig
Copy link
Contributor

Maybe I am misunderstanding this, but couldn't we just modify the build script to be something like "build": "rollup --config && pnpm i -f",? We are basically doing this here, only at the CI workflow level. Not saying this is nice, but would it work?

@NullVoxPopuli
Copy link
Contributor Author

on a cache-hit, the entirety of the build script would be skipped, and the links in node_modules/.pnpm not updated

@simonihmig
Copy link
Contributor

Oh, right. This was the missing bit 😔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants