Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

#99: Revert pnpm version pinning to use latest again after 7.30.3 fixes our issue #101

Merged
merged 1 commit into from Mar 27, 2023

Conversation

ynotdraw
Copy link
Contributor

@ynotdraw ynotdraw commented Mar 24, 2023

馃殌 Description

pnpm v7.30.3 has been merged and our issue is closed! https://github.com/pnpm/pnpm/releases/tag/v7.30.3 (pnpm/pnpm#6271)

Confirmed the action is now using 7.30.3! https://github.com/CrowdStrike/ember-toucan-core/actions/runs/4516067783/jobs/7954046644?pr=101#step:3:28

Closes #99


馃敩 How to Test

  • Green build

馃摳 Images/Videos of Functionality

N/A

@ynotdraw ynotdraw self-assigned this Mar 24, 2023
@changeset-bot
Copy link

changeset-bot bot commented Mar 24, 2023

鈿狅笍 No Changeset found

Latest commit: ca2f3de

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Mar 24, 2023

Preview URLs

GH Env: preview
docs: https://530d2b3a.ember-toucan-core.pages.dev

@ynotdraw ynotdraw force-pushed the 99-revert-pnpm-back-to-latest branch from 71b44f9 to ca2f3de Compare March 24, 2023 23:08
@ynotdraw ynotdraw changed the title #99: Revert pnpm version back to latest due to 7.30.2 release #99: Revert pnpm version pinning to use latest again after 7.30.3 fixes our issue Mar 24, 2023
@ynotdraw ynotdraw marked this pull request as ready for review March 24, 2023 23:13
@ynotdraw ynotdraw merged commit d1e0fb8 into main Mar 27, 2023
17 checks passed
@ynotdraw ynotdraw deleted the 99-revert-pnpm-back-to-latest branch March 27, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Look into pnpm issue with version 7.30.1
3 participants