#40: Add turbo and pnpm syncing support

[ynotdraw]

🚀 Description

This PR adds turbo and pnpm syncing to match ember-headless-form. This PR should align with what is in CrowdStrike/ember-headless-form#52.

This cuts CI time by ~2mins, or in half!

Closes #40

---

🔬 How to Test

No visual changes, all CI related

• Green build

---

📸 Images/Videos of Functionality

N/A

[changeset-bot]

⚠️ No Changeset found

Latest commit: 43facb4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[github-actions]

Preview URLs

Env: preview
Docs: https://1e659abb.ember-toucan-core.pages.dev

[ynotdraw]

This is now accomplished with the lint step above instead of being in a separate step 🎉

[ynotdraw]

Went ahead and deleted this comment as we aren't doing these yet (but also no plan to soon™).

[nicolechung]

For local development, do we still have to set up pnpm link @crowdstrike/ember-toucan-core and pnpm i (without committing the related package.json changes?

Build Error (WaitForTrees)

@crowdstrike/ember-toucan-core/package.json lists ./dist/_app_/components/button.js in ember-addon.app-js, but that file does not exist


Stack Trace and Error Report: /var/folders/jc/81dkjn9s2sg5cpt_66jd8l640000gn/T/error.dump.c5cd0949f5a2005a23bb20913f0234cf.log

Without that I am still getting this error...

I do notice that the docs-app watches for changes now when I change something in package/ember-toucan-core which is exciting!

[nicolechung]

Oh do I have to run this script locally?

[ynotdraw]

Nope! You can still use pnpm linking locally as it works today!

[ynotdraw]

For local development, do we still have to set up pnpm link @crowdstrike/ember-toucan-core and pnpm i (without committing the related package.json changes?

@nicolechung Yup! We will still need to do this for now

Build Error (WaitForTrees)

@crowdstrike/ember-toucan-core/package.json lists ./dist/_app_/components/button.js in ember-addon.app-js, but that file does not exist


Stack Trace and Error Report: /var/folders/jc/81dkjn9s2sg5cpt_66jd8l640000gn/T/error.dump.c5cd0949f5a2005a23bb20913f0234cf.log

Without that I am still getting this error...

I do notice that the docs-app watches for changes now when I change something in package/ember-toucan-core which is exciting!

Interesting. Can you provide some reproduction steps? I tried the following with success:

rm -rf node_modules
pnpm I
# a build is still required for the docs-app/test-app to consume core!
cd packages/ember-toucan-core
pnpm build
cd ../../docs-app/
pnpm start

and then from the root:

pnpm start:docs

I wonder if your node_modules were in a weird state or something? Based on the error message I'd also guess that maybe there's not a build for toucan-core so running pnpm build within the core package may be all that's missing there.

May also try rm -rf node_modules from within the docs-app directory and re-pnpm iing before starting? Nothing should change workflow wise for us with these changes, so if this is failing we definitely need to fix!

[nicolechung]

May also try rm -rf node_modules from within the docs-app directory and re-pnpm iing before starting? Nothing should change workflow wise for us with these changes, so if this is failing we definitely need to fix!

I did a full nuke (rm -rf node_modulesfrom all packages and apps) before starting...let me try it again and make sure all thenode_modules` are cleared)...

But I didn't do pnpm link.

[simonihmig]

🎉