Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade ember-template-lint #166

Merged
merged 1 commit into from
May 29, 2023
Merged

Conversation

ynotdraw
Copy link
Contributor

馃殌 Description

This PR upgrades ember-template-lint to the latest which has a bug fix from @NullVoxPopuli that allows us to remove some overrides


馃敩 How to Test

  • Green build - only affects CI

馃摳 Images/Videos of Functionality

N/A

@changeset-bot
Copy link

changeset-bot bot commented May 24, 2023

鈿狅笍 No Changeset found

Latest commit: d064434

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

Preview URLs

Env: preview
Docs: https://f378e787.ember-toucan-core.pages.dev

@ynotdraw ynotdraw marked this pull request as ready for review May 24, 2023 13:06
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a lot more changes here than I would expect... Maybe try reverting these and rerunning pnpm install?

Copy link
Contributor Author

@ynotdraw ynotdraw May 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is quite big, but this is exactly what pnpm i yields! pnpm ends up having a lot more lock file changes than yarn typically would due to the way it handles dependencies (so when you upgrade a package, for example, if that package added new dependencies, you'll see more changes your lock file).

@ynotdraw ynotdraw merged commit a82e9c9 into main May 29, 2023
14 checks passed
@ynotdraw ynotdraw deleted the chore-upgrade-ember-template-lint branch May 29, 2023 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants