Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#43: Upgrade to latest eslint-plugin-ember, remove eslint-disable, and make --fix work again #181

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

ynotdraw
Copy link
Contributor

@ynotdraw ynotdraw commented Jun 13, 2023

🚀 Description

This PR upgrades us to the latest eslint-plugin-ember and removes the eslint-disable comments in our gts files. Fixed via:

With this change, you can now click the lightbulb in VS Code > Auto-fix all issues. Or via the CLI you can do pnpm lint:js:fix to resolve all eslint issues automatically.

Closes #43


🔬 How to Test

  • Green build

📸 Images/Videos of Functionality

N/A

@ynotdraw ynotdraw self-assigned this Jun 13, 2023
@changeset-bot
Copy link

changeset-bot bot commented Jun 13, 2023

⚠️ No Changeset found

Latest commit: 83e692e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

Preview URLs

Env: preview
Docs: https://ca81cb49.ember-toucan-core.pages.dev

@@ -1,16 +1,13 @@
/* eslint-disable no-undef -- Until https://github.com/ember-cli/eslint-plugin-ember/issues/1747 is resolved... */
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I can also get rid of this now due to glimmerjs/glimmer-vm#1406 being merged, but I'll test that out and put up a separate PR for those changes to keep these focused on the --fix path

@ynotdraw ynotdraw marked this pull request as ready for review June 13, 2023 23:41
@ynotdraw ynotdraw changed the title #43: Upgrade to latest eslint-plugin-ember, remove eslint-disable #43: Upgrade to latest eslint-plugin-ember, remove eslint-disable, and make --fix work again Jun 13, 2023
Copy link
Contributor

@simonihmig simonihmig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 😍

TIL about ember-cli/eslint-plugin-ember#1853, need to pull that into headless-forms as well!

@ynotdraw ynotdraw merged commit e41d627 into main Jun 14, 2023
14 checks passed
@ynotdraw ynotdraw deleted the upgrade-to-latest-eslint-plugin-ember branch June 14, 2023 18:35
simonihmig added a commit to CrowdStrike/ember-headless-form that referenced this pull request Jun 28, 2023
simonihmig added a commit to CrowdStrike/ember-headless-form that referenced this pull request Jun 28, 2023
simonihmig added a commit to CrowdStrike/ember-headless-form that referenced this pull request Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test app: lint fix does not autosort imports
5 participants