Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade-graphql-codegen-cli #344

Merged
merged 2 commits into from
Mar 15, 2022
Merged

upgrade-graphql-codegen-cli #344

merged 2 commits into from
Mar 15, 2022

Conversation

TheNoodleMoose
Copy link
Contributor

Based on this GH thread. Ideally, this would fix the issue we've been experiencing(🤞), but if not at least we will get better error message outputs in the CLI that will hopefully help us to identify what the root issue is.

@vercel
Copy link

vercel bot commented Mar 10, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/cru/mpdx-react/88ya9BAs5MdT99a8sLbtnPDKcZgd
✅ Preview: https://mpdx-react-git-upgrade-graphql-codegen-cli-cru.vercel.app

@wrandall22
Copy link
Contributor

Well, there do seem to be some better error messages.

@TheNoodleMoose
Copy link
Contributor Author

Shame as it appeared to work locally when I ran the typescript lint check. Definitely some better error messages. I'll try to mess with it a bit more and see if I can get something working.

@wrandall22
Copy link
Contributor

So, do we still get the improved error messages in 2.3.0? Or are we hoping that it will just resolve the issues?

@TheNoodleMoose
Copy link
Contributor Author

I think the latter, there's something that changes with version 2.5.0 that breaks the codegen we have. Probably need to investigate and see what changed with that version that would cause issues. But I'm hoping the improvements with 2.3.0 will make things more stable in the CI.

@wrandall22 wrandall22 merged commit 617b243 into main Mar 15, 2022
@wrandall22 wrandall22 deleted the upgrade-graphql-codegen-cli branch March 15, 2022 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants