Add internal and external traffic policy to crd. #3812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(a) Thanks for this (b) I'm not sure if that's where we'd want to put a field to affect the pgbouncer service, but I want to talk more to the team and will update you if we have suggestions on this PR. |
|
@cbandy this is that PR for trafficPolicy I talked to you about. |
cbandy
requested changes
Jan 16, 2024
There was a problem hiding this comment.
Thanks @baptman21! The struct for PgBouncer affects other parts of the CRD, so I've recommended a few changes.
pkg/apis/postgres-operator.crunchydata.com/v1beta1/shared_types.go
Outdated
Show resolved
Hide resolved
config/crd/bases/postgres-operator.crunchydata.com_postgresclusters.yaml
Outdated
Show resolved
Hide resolved
config/crd/bases/postgres-operator.crunchydata.com_postgresclusters.yaml
Outdated
Show resolved
Hide resolved
baptman21
force-pushed
the
add-traffic-policy-to-service-crd
branch
from
baeeeea
to
810b1b3
Compare
|
@cbandy Thank you for the review, I added the changes you proposed. Tell me if anything else is missing. |
|
Hello @cbandy, did you have time to check this PR with my changes ? |
cbandy
approved these changes
Apr 22, 2024
To allow more modifications to the service created for the pgboucer, add the externalTrafficPolicy and internalTrafficPolicy to the CRD of the service. Issue: CrunchyData#3797
Co-authored-by: Chris Bandy <bandy.chris@gmail.com>
Update the type and comment that link the docs. Made with the `make generate-crds`.
jmckulk
force-pushed
the
add-traffic-policy-to-service-crd
branch
from
810b1b3
to
c3bda0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow more modifications to the service created for the pgboucer, add the externalTrafficPolicy and internalTrafficPolicy to the CRD of the service.
Issue: #3797
Checklist:
Type of Changes:
What is the current behavior (link to any open issues here)?
Not possible to set traffic policies in services.
#3797
What is the new behavior (if this is a feature change)?
Other Information: