Revise delete tests #3822
Revise delete tests #3822
Conversation
* Use files for legibility * Add describe/log collectors to every assert
|
Actually, this is low priority |
| apiVersion: kuttl.dev/v1beta1 | ||
| kind: TestStep | ||
| apply: | ||
| - files/00-create-namespace.yaml |
There was a problem hiding this comment.
I don't see a files/00-create-namespace.yaml
There was a problem hiding this comment.
copy-paste error
There was a problem hiding this comment.
Maybe this test could be in a different directory?
testing/kuttl/e2e
delete/
00-create...
delete-<descriptive-suffix>/
10-create...
also maybe not, having each delete type in a directory makes sense too.
A better name on 10-* would be appreciated. To see that it is deleting a replica cluster without having to click into the create-cluster.yaml file or the readme
There was a problem hiding this comment.
Better names, check
|
|
||
| * Start a regular cluster with 2 replicas | ||
| * Delete it | ||
| * Check that nothing remains | ||
|
|
||
| #### Delete a cluster that never started | ||
| #### Delete a cluster that never started (20-21) |
There was a problem hiding this comment.
Do we need to check this? Kube should cleanup the resources regardless of the cluster status
There was a problem hiding this comment.
Hmmm, I think this test was to check that we didn't have a finalizer on the cluster that made it impossible to delete while not running.
There was a problem hiding this comment.
would it make sense to put this in a TestStep - to be consistent with the delete-namespace test/other tests?
There was a problem hiding this comment.
According to the docs, the delete happens at the beginning of the step, so I think a delete/errors teststep might work. Eh, I avoided it in case that wasn't the case, but I'll try it
| - type: command | ||
| command: kubectl -n ${KUTTL_TEST_DELETE_NAMESPACE} describe pods --selector postgres-operator.crunchydata.com/cluster=delete-namespace | ||
| - namespace: ${KUTTL_TEST_DELETE_NAMESPACE} | ||
| selector: postgres-operator.crunchydata.com/cluster=delete-namespace |
There was a problem hiding this comment.
⛏️ Missing newlines on a few of the files.
Checklist:
Type of Changes:
What is the current behavior (link to any open issues here)?
What is the new behavior (if this is a feature change)?
Other Information: