Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise major-upgrade tests #3823

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Revise major-upgrade tests #3823

wants to merge 2 commits into from

Conversation

benjaminjb
Copy link
Contributor

Checklist:

  • Have you added an explanation of what your changes do and why you'd like them to be included?
  • Have you updated or added documentation for the change, as applicable?
  • Have you tested your changes on all related environments with successful results, as applicable?
    • Have you added automated tests?

Type of Changes:

  • New feature
  • Bug fix
  • Documentation
  • Testing enhancement
  • Other

What is the current behavior (link to any open issues here)?

What is the new behavior (if this is a feature change)?

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Use files for legibility
  • Add describe/log collectors to every assert

Other Information:

@benjaminjb
Revise major-upgrade tests
b56ba83 
* Use files for legibility
* Add describe/log collectors to every assert
@benjaminjb
test asserts gotta be named assert
0c9df81
@benjaminjb
Copy link
Contributor Author

I think we're going to have to update all the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmckulk jmckulk Awaiting requested review from jmckulk

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@benjaminjb