update to VRFV2 #681
Open
update to VRFV2 #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pappas999 Thank you for taking the time to create this PR. I see that you updated all the |
|
thanks @andreipope , I updated the previous lessons as well. Everything should be consistent now |
TomiOhl
suggested changes
Jun 8, 2022
|
thanks @TomiOhl , I incorporated the feedback given. Please take a look when you can, thanks! |
TomiOhl
suggested changes
Jun 23, 2022
en/19/11.md
Outdated
| function fulfillRandomness(bytes32 requestId, uint256 randomness) internal override { | ||
| randomResult = randomness; | ||
| function _createZombie(string memory _name, uint _dna) private { | ||
| zombies.push(Zombie(_name, _dna)); | ||
| } | ||
|
|
||
| // Delete the function below |
There was a problem hiding this comment.
To be complete, a "1." should be added here
|
thanks @TomiOhl , i added the change, as well as a couple others I spotted on other pages while doing a check through again. |
TomiOhl
approved these changes
Jun 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated Chainlink VRF section to use the new Chainlink VRF V2