Parseexception with ancestors fix #365
Conversation
Signed-off-by: David Meibusch <david.meibusch@oracle.com>
Explicitly handle the parsing of components when parsing from the token buffer. This happens in `MetadataDeserializer` when the token stream is materialized to a JsonNode and then "re-parsed" (hence no longer an XML-based stream) Signed-off-by: David Meibusch <david.meibusch@oracle.com>
|
|
||
| wrapper.setComponents(Arrays.asList(components)); | ||
|
|
||
| List<Component> components = Collections.emptyList(); |
There was a problem hiding this comment.
As far as I can determine, the issue arises due to MetadataDeserializer using the shortcut of reading the tree from the XML (this is only an XML issue) token stream, then using a unconfigured ObjectMapper to convert to the target types. The context is then lost (e.g. XML parser, XML deserialization context) within child deserializers and we enter this deserializer re-parsed then tree now as plain JSON tokens with a vanilla JSON parser.
This list of components (when nested in metadata/../ancestors etc) might be absent (no tokens), a single object, or an array of objects. Fix here is to explicitly handle these cases.
Not 100% happy - still a hack on top of the existing hack to handle component object lists. 🤷
|
Thanks for identifying the issue. I should have time to review in a week or two. |
Fix for #363
Adds a test case for the issue, then a commit for a proposed fix.