Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Improvements #376

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Code Improvements #376

wants to merge 2 commits into from
+197 −229

Conversation

mr-zepol
Copy link
Contributor

This PR:

  • Reduce code duplication
  • Polish code

@mr-zepol mr-zepol force-pushed the code_improvements branch 4 times, most recently from 77afdff to 360b7a0 Compare March 21, 2024 13:48
@mr-zepol mr-zepol added the enhancement New feature or request label Mar 21, 2024
@stevespringett
Copy link
Member

Could you resolve the conflicts on this?

@mr-zepol
Copy link
Contributor Author

Could you resolve the conflicts on this?

Sure, looking into it

@mr-zepol mr-zepol force-pushed the code_improvements branch 2 times, most recently from f2894af to 56ac35d Compare May 14, 2024 19:09
@mr-zepol
Copy link
Contributor Author

Could you resolve the conflicts on this?

@stevespringett conflicts resolved

@stevespringett
Copy link
Member

Looks like the last merge with the license corrections created yet another conflict.

@mr-zepol
Polish Code and reduce duplicate code
888e868 
Signed-off-by: Alex Alzate <aalzate@sonatype.com>
@mr-zepol
Copy link
Contributor Author

Looks like the last merge with the license corrections created yet another conflict.

@stevespringett I resolved the conflicts

@mr-zepol
Remove unused fields
110a892 
Signed-off-by: Alex Alzate <aalzate@sonatype.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nscuro nscuro nscuro approved these changes

@stevespringett stevespringett Awaiting requested review from stevespringett

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mr-zepol @stevespringett @nscuro