Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.6 support #140

Open
Razikus opened this issue Apr 11, 2024 · 8 comments
Open

1.6 support #140

Razikus opened this issue Apr 11, 2024 · 8 comments
Labels
help wanted Extra attention is needed spec/1.6

Comments

@Razikus
Copy link

Razikus commented Apr 11, 2024

Is there any ETA when 1.6 spec will be compatible with this library?

@nscuro
Copy link
Member

nscuro commented Apr 11, 2024

No ETA. I am currently swamped with other responsibilities :(

Community contributions would help in getting this done sooner.

@Razikus
Copy link
Author

Razikus commented Apr 19, 2024

thats sad, its official library for cyclonedx :(

@Razikus
Copy link
Author

Razikus commented Apr 30, 2024

bump

@nscuro
Copy link
Member

nscuro commented Apr 30, 2024

@Razikus Please stop commenting "bump". It does not help.

@Razikus
Copy link
Author

Razikus commented Apr 30, 2024

@Razikus Please stop commenting "bump". It does not help.

Sorry

@mcombuechen
Copy link
Contributor

Hey @nscuro

we (some of the folks at Snyk) would love to help out with this. Since this should probably happen in smaller chunks, we wonder how we can best contribute without stepping on other contributors toes (e.g. there's already a good looking PR for the CBOM model).

Suggestion would be to create a spec/1.6 (name TBD) branch and start merging small PRs into it. We should probably also fan out into smaller GitHub issues with the spec/1.6 for a comprehensive list of all the required changes. We're happy to help with that, too.

What do you think?

@nscuro
Copy link
Member

nscuro commented May 7, 2024

Thanks so much @mcombuechen, that sounds awesome! I branched off spec/1.6 from the current master.

We should probably also fan out into smaller GitHub issues with the spec/1.6 for a comprehensive list of all the required changes.

That would be great, yes. But will require a bit of research. In the past I went by the PRs in the respective spec milestone.

Anything you need from my side to kickstart this?

In any case I am more than happy to help if you have any questions about the code base etc.

@mcombuechen
Copy link
Contributor

Thanks @nscuro

But will require a bit of research.

We already did a bit of research based on diffs between the 1.5 and 1.6 JSON schemas; I had not been aware of the spec milestones, will look into those as well. I can make a start by creating some issues, if we happen to miss anything please shout! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed spec/1.6
Projects
None yet
Development

No branches or pull requests

3 participants