Feat: Support CBOM (1.6 specification) (#140) #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Petzys <87223648+Petzys@users.noreply.github.com>
Signed-off-by: Petzys <87223648+Petzys@users.noreply.github.com>
Signed-off-by: Petzys <87223648+Petzys@users.noreply.github.com>
nscuro
reviewed
Apr 25, 2024
cyclonedx.go
Outdated
| AssetTypeRelatedCryptoMaterial AssetType = "related-crypto-material" | ||
| ) | ||
|
|
||
| type Primitive string |
There was a problem hiding this comment.
Some of these types have rather generic names (e.g. Primitive, Mode). We need to pay attention that we won't cause naming collisions as the spec grows. Consider prefixing some of these types so they're "pseudo-namespaced". For example CryptoPrimitive instead of Primitive.
There was a problem hiding this comment.
Yup, I see your point and I agree. I think Crypto works as a prefix. I will work on that.
Signed-off-by: Petzys <87223648+Petzys@users.noreply.github.com>
This was referenced May 8, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃毀 WIP 馃毀
This PR is meant to implement the CBOM specification from specification 1.6. It might be extended to include to full scope of 1.6.
As I mainly use this module to decode JSON BOMs, I might or might not continue development on this PR. Contributions of any kind are highly appreciated.
Partly addresses #140.