Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PHP8.1] use readonly properties #141

Open
1 of 3 tasks
jkowalleck opened this issue Sep 25, 2022 · 1 comment · May be fixed by #252
Open
1 of 3 tasks

[PHP8.1] use readonly properties #141

jkowalleck opened this issue Sep 25, 2022 · 1 comment · May be fixed by #252
Assignees
@jkowalleck
Labels
breaking change

Comments

@jkowalleck
Copy link
Member

jkowalleck commented Sep 25, 2022 •
edited

currently readonly properties are private, annotated as @readonly and available via a getter.

since php8.1 native support for readonly properties exists.

proposal

attention

  • there are issues when it comes to modifications in __clone() - -therefore, not fully rolled out
  • there are extended works needed to make the test cases aware ...
  • failed try: [WIP] use readonly properties #207
@jkowalleck jkowalleck added this to the v2 milestone Feb 4, 2023
@jkowalleck jkowalleck self-assigned this Feb 5, 2023
@jkowalleck jkowalleck mentioned this issue Feb 5, 2023
Closed
@jkowalleck jkowalleck removed this from the v2 milestone Feb 6, 2023
@jkowalleck jkowalleck added the idea label Feb 6, 2023
@jkowalleck jkowalleck mentioned this issue Feb 10, 2023
Merged
@jkowalleck jkowalleck added this to the v2 milestone Mar 8, 2023
@jkowalleck
Copy link
Member Author

jkowalleck commented Mar 8, 2023 •
edited

there are a couple of readonly properties, now.
some are private, but there is still a getter for them. why? this can be optimized.

@jkowalleck jkowalleck removed this from the v2 milestone Mar 10, 2023
@jkowalleck jkowalleck removed the idea label Mar 10, 2023
@jkowalleck jkowalleck added this to the v2 milestone Mar 10, 2023
@jkowalleck jkowalleck linked a pull request Mar 10, 2023 that will close this issue
Draft
3 tasks
@jkowalleck jkowalleck removed this from the v2 milestone Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jkowalleck jkowalleck

Labels
breaking change
Projects
None yet
Milestone
No milestone
1 participant
@jkowalleck