Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC: readonly public access no getter #252

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jkowalleck
Copy link
Member

@jkowalleck jkowalleck commented Mar 10, 2023

fixes #141


  • implement
  • document in HISTORY
  • adjust tests -- this is a lot work. is it worth it?

@jkowalleck jkowalleck changed the title Readonly public access no getter BC: readonly public access no getter Mar 10, 2023
@@ -26,22 +26,19 @@
use CycloneDX\Core\Spec\Spec;

/**
* @internal as this class may be affected by breaking changes without notice
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ revert

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck force-pushed the readonly-public-access-no-getter branch from ef95580 to 62d145b Compare March 10, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PHP8.1] use readonly properties
1 participant