Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reduce code duplication #157

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

reduce code duplication #157

wants to merge 1 commit into from

Conversation

jkowalleck
Copy link
Member

@jkowalleck jkowalleck commented Oct 9, 2022 •
edited

fixes #36

  • introduce a QA tool to detect code duplicates
  • configure the tool
  • have the tool as part of default test suite
  • have the tool as part of CI/CT
  • reduce duplicate code

@jkowalleck jkowalleck added this to the v2 milestone Oct 9, 2022
@jkowalleck
add QA tool: phpcpd
9421894 
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck removed this from the v2 milestone Oct 10, 2022
@jkowalleck
Copy link
Member Author

currently detected duplicated code could be moved to a trait.
but for typing i would need templates. and templates in traits are not properly working with psalm.
maybe this changes in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

reduce code duplication
1 participant
@jkowalleck