Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allows subdag to be async #905

Merged
merged 1 commit into from
May 14, 2024
Merged

Allows subdag to be async #905

merged 1 commit into from
May 14, 2024

Conversation

elijahbenizzy
Copy link
Collaborator

This just adds another path for the two functions we redefine. We need to add tests but this works on a manual test for now.

See #903

Changes

How I tested this

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

@elijahbenizzy elijahbenizzy mentioned this pull request May 14, 2024
Closed
skrawcz
skrawcz reviewed May 14, 2024
View reviewed changes
hamilton/version.py Outdated Show resolved Hide resolved
@elijahbenizzy
Allows subdag to be async
fd42a8e 
This just adds another path for the two functions we redefine. We need
to add tests but this works on a manual test for now.

See #903
@elijahbenizzy elijahbenizzy changed the title Allows subdag to be async (WIP) Allows subdag to be async May 14, 2024
@elijahbenizzy elijahbenizzy merged commit dc87f97 into main May 14, 2024
23 checks passed
@elijahbenizzy elijahbenizzy deleted the async-subdag branch May 14, 2024 21:19
@skrawcz skrawcz linked an issue May 14, 2024 that may be closed by this pull request
Decorator like @subdag that works with async functions #903
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skrawcz skrawcz skrawcz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Decorator like @subdag that works with async functions
2 participants
@elijahbenizzy @skrawcz