Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding code to run on Powersystem #243

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

genisysram
Copy link

Hi
Here is my contribution to your code, its working good on powersystems.

Thanks for the code, its working good.

What do these changes do?

Added Architecture "ppc64le"

Are there changes in behavior for the user?

No

@codecov-io
Copy link

codecov-io commented Oct 29, 2020

Codecov Report

Merging #243 into master will decrease coverage by 0.61%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #243      +/-   ##
==========================================
- Coverage   94.59%   93.98%   -0.62%     
==========================================
  Files          19       19              
  Lines         980      814     -166     
==========================================
- Hits          927      765     -162     
+ Misses         38       34       -4     
  Partials       15       15              
Impacted Files Coverage Δ
rows_go18.go 88.88% <0.00%> (-3.97%) ⬇️
expectations.go 84.25% <0.00%> (-2.89%) ⬇️
expectations_before_go18.go 85.18% <0.00%> (-1.92%) ⬇️
sqlmock.go 92.39% <0.00%> (-0.92%) ⬇️
expectations_go18.go 94.87% <0.00%> (-0.59%) ⬇️
rows.go 88.73% <0.00%> (-0.40%) ⬇️
query.go 100.00% <0.00%> (ø)
column.go 100.00% <0.00%> (ø)
driver.go 100.00% <0.00%> (ø)
result.go 100.00% <0.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f920cc8...748dc15. Read the comment docs.

@l3pp4rd
Copy link
Member

l3pp4rd commented Nov 10, 2020

Hi, this package is not using unsafe, just mimics the standard sql driver.
I do not see the point in testing different archs, which are supported by go.

@genisysram
Copy link
Author

@ashhadsheikh
Hi please accept my PR

@gagantrivedi
Copy link
Collaborator

Hey @genisysram, as @l3pp4rd have already pointed out that this package is not using unsafe so there is no point in testing it on different architecture. Unless you have a different reason in mind we will probably have to close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants