Integrate Psalm #10
Merged
Integrate Psalm #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
February 6, 2023 17:35
This is a generated setup with a few changes: - Reduce the error level from 7 to 3, which finds more issues. - Configure `findUnusedCode="false"` to avoid a warning about it. - Disable extensions "apcu" and "redis". This was recommended by Psalm itself in some warnings that were generated during the GitHub pipeline runs. - Enable FFI extension explicitly. Psalm uses the ones from composer.json by default, but FFI is only marked as a suggestion.
Psalm is almost clueless about FFI and its structure. Support for it was only added recently and is far from complete yet.
UlrichEckhardt
force-pushed
the
feature/psalm
branch
from
fd949fc
to
4955a23
Compare
UlrichEckhardt
force-pushed
the
feature/psalm
branch
from
4955a23
to
7d25bb5
Compare
fabiante
approved these changes
Feb 7, 2023
MrBalum
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
@psalm-suppressannotations for FFI stuff. Support for FFI in Psalm is mediocre.Notes:
--show-info=true, there are some more warnings raised by Psalm, but these are not addressed here.@psalm-suppressannotations, see Improved FFI integration vimeo/psalm#9230 for further info.